Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Progress indicator jumps #166

Closed
koppor opened this issue Aug 29, 2024 · 9 comments
Closed

Progress indicator jumps #166

koppor opened this issue Aug 29, 2024 · 9 comments

Comments

@koppor
Copy link
Collaborator

koppor commented Aug 29, 2024

image

Maybe, there should be a global task for the group chat waiting for injection? Started before all the tasks and closed afterwards? Just for loading indication?

Refs #165

Refs JabRef#11666
@InAnYan
Copy link
Owner

InAnYan commented Aug 29, 2024

How exactly progress indicator jumps? Backwards/forward?

How did you expect it to jump?

global task for the group chat waiting for injection

Intesting idea

@koppor
Copy link
Collaborator Author

koppor commented Aug 29, 2024

How exactly progress indicator jumps? Backwards/forward?

Fills, then back. Fills, then back.

Seems like only five tasks are executed in parallel. If one is finished, the next is added.

Just try with 100 PDFs.

How did you expect it to jump?

If JabRef says: I index 100 PDFs, then the progress should increase by each PDF. And not jump to 60% if 5 of the 100 are indexed.

@InAnYan
Copy link
Owner

InAnYan commented Aug 31, 2024

Ahhh I see, a thread pool......

Okay, the idea of a one task for full group is good

InAnYan added a commit that referenced this issue Aug 31, 2024
@InAnYan
Fix for #166
9d87a7b
@InAnYan
Copy link
Owner

InAnYan commented Aug 31, 2024

Phew...

It was a challenge.

Should work properly

@InAnYan InAnYan added the status: waiting-for-feedback The submitter needs to recheck the issue or provide more information about the issue label Aug 31, 2024
@koppor koppor mentioned this issue Sep 3, 2024
Open
@koppor
Copy link
Collaborator Author

koppor commented Sep 3, 2024

State of today

image

I don't see any more which files are indexed. - Can the filename be shown in the status (11 out of 35 ..; currently: abc.pdf)? Or at the task name (Indexing for ... - abc.pdf)

@koppor koppor removed the status: waiting-for-feedback The submitter needs to recheck the issue or provide more information about the issue label Sep 3, 2024
@InAnYan
Copy link
Owner

InAnYan commented Sep 4, 2024

Which file is indexed right now? Yes it can be, 5 files are ingested at once, so:

  1. Should I list all 5 files
  2. or process only one file at a time (that may be better if user has some other background tasks)

@InAnYan InAnYan added the status: waiting-for-feedback The submitter needs to recheck the issue or provide more information about the issue label Sep 4, 2024
@koppor
Copy link
Collaborator Author

koppor commented Sep 4, 2024

Which file is indexed right now? Yes it can be, 5 files are ingested at once, so:

1. Should I list all 5 files
  • Option 1: The first and then , ...
  • Option 2: The largest and then , ...
2. or process only one file at a time (that may be better if user has some other background tasks)

No. We should make use of our multi corse.

@koppor koppor removed the status: waiting-for-feedback The submitter needs to recheck the issue or provide more information about the issue label Sep 4, 2024
InAnYan added a commit that referenced this issue Sep 4, 2024
@InAnYan
Fix for #166 and fix for #176
2c8650f
@InAnYan
Copy link
Owner

InAnYan commented Sep 4, 2024

Should be implemented

@InAnYan InAnYan added the status: waiting-for-feedback The submitter needs to recheck the issue or provide more information about the issue label Sep 4, 2024
@koppor
Copy link
Collaborator Author

koppor commented Sep 4, 2024

text cut off, but this is OK

image

Wider window:

image

@koppor koppor closed this as completed Sep 4, 2024
@koppor koppor removed the status: waiting-for-feedback The submitter needs to recheck the issue or provide more information about the issue label Sep 4, 2024
github-merge-queue bot pushed a commit to JabRef/jabref that referenced this issue Sep 4, 2024
@InAnYan @koppor
Chat with groups + AI chat UI and logic overhaul (#11666)
7f7726e 
* AI chat UI overhaul

* Chat history and AI chat overhaul

* Implement ingestion logic

* Implement ingestion logic

* Accept list of entries

* Group chat history logic

* Move components to folders and introduce AiPrivacyNoticeGuardedComponent

* Move components to folders and introduce AiPrivacyNoticeGuardedComponent

* Introduce EmbeddingModelGuardedComponent

* SummaryComponent overhaul

* Summarization logic overhaul

* Finish work on refactoring the summarization

* Introduce group chats

* Introduce group chat

* Refactor AI code

* AI chat UI overhaul

* Chat history and AI chat overhaul

* Implement ingestion logic

* Implement ingestion logic

* Accept list of entries

* Group chat history logic

* Move components to folders and introduce AiPrivacyNoticeGuardedComponent

* Move components to folders and introduce AiPrivacyNoticeGuardedComponent

* Introduce EmbeddingModelGuardedComponent

* SummaryComponent overhaul

* Summarization logic overhaul

* Finish work on refactoring the summarization

* Introduce group chats

* Introduce group chat

* Refactor AI code

* Fix GenerateEmbeddingsTask

* Introduce windows

* Refactor notifications

* No linting errors occurring

* Improve chat history component

* Discard changes to src/main/java/module-info.java

* Refine JavaDoc

* Fix for InAnYan#173

* Fix for InAnYan#171

* Fix from code review

* Fix checkers

* Fix for InAnYan#175 and InAnYan#174

* Follow-up for InAnYan#175

* Fix for InAnYan#166

* Fix for InAnYan#164

* Fix checkers

* Fix from code review

* Update src/main/java/org/jabref/gui/ai/components/aichat/AiChatGuardedComponent.java

Co-authored-by: Oliver Kopp <[email protected]>

* Fix for InAnYan#166 and fix for InAnYan#176

* Might be fix for InAnYan#178

* Migrate from AbstractGroup to GroupTreeNode

* Fix for InAnYan#170

* Fix for InAnYan#164

* InAnYan#177

* Fix for InAnYan#180

* Fix checkers

* Fix the system message

* Fix for InAnYan#180

* Fix context menu order

* Fix `startsWith`

* Fix system message

* Fix for ProgressCounter

* Fix for system message

---------

Co-authored-by: Oliver Kopp <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@koppor @InAnYan