Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

No files found is a warning, not an error #176

Open
koppor opened this issue Aug 30, 2024 · 15 comments
Open

No files found is a warning, not an error #176

koppor opened this issue Aug 30, 2024 · 15 comments
Milestone
Chat with a group...

Comments

@koppor
Copy link
Collaborator

koppor commented Aug 30, 2024

image

An error is something that blocks the result (like exceptions). A missing file is nothing that special.

Please change to warning.

The only error is if no file is attached at all, because then no chatting is possible.
@InAnYan
Copy link
Owner

InAnYan commented Aug 31, 2024

Notifications window looks good on your machine)

@InAnYan
Copy link
Owner

InAnYan commented Aug 31, 2024

Now, to the issue:

I've made it an error because it blocks the chatting with the entry, so AI won't be able to give any results from the entry because there are no files attached.

The only error is if no file is attached at all, because then no chatting is possible.

I think you meant if all entries don't have attached files?

If we remove error from here, then notifications probably shouldn't have types.

So should I remove it?

@InAnYan
Copy link
Owner

InAnYan commented Aug 31, 2024 •
edited
Loading

Hmm, maybe it would be better to rename notifications (or tooltip) to something else... like "files status", or "AI chat status".

But "notifications" seems easy

@InAnYan InAnYan added the status: waiting-for-feedback The submitter needs to recheck the issue or provide more information about the issue label Aug 31, 2024
@koppor
Copy link
Collaborator Author

koppor commented Sep 3, 2024

State of today

image

@koppor
Copy link
Collaborator Author

koppor commented Sep 3, 2024

Now, to the issue:

I've made it an error because it blocks the chatting with the entry, so AI won't be able to give any results from the entry because there are no files attached.

I am chatting with a group of bib entries. two hundred. I am able to chat.

So should I remove it?

You can keep LOGGER.debug. But not do a notification.

I am talking about the group chat!!!

For single AI chat tab, it works.

@koppor
Copy link
Collaborator Author

koppor commented Sep 3, 2024

The thing is, JabRef has a nice UI to show for which entries in a group there is no attached file:

image

There is no need to put warnings. A user should know that chatting with content requries content.

@koppor koppor removed the status: waiting-for-feedback The submitter needs to recheck the issue or provide more information about the issue label Sep 3, 2024
@InAnYan
Copy link
Owner

InAnYan commented Sep 4, 2024

@koppor I see. Should I remove notification "No files attached" whatsoever?

@InAnYan
Copy link
Owner

InAnYan commented Sep 4, 2024 •
edited
Loading

And it doesn't mean that you won't be able to chat. It says "AI won't extract information from those entries".

Can I leave only one notification, where I list all the entries without files? Well, probably that's not a good idea, if there are many entries without files

@koppor
Copy link
Collaborator Author

koppor commented Sep 4, 2024

And it doesn't mean that you won't be able to chat. It says "AI won't extract information from those entries".

Can I leave only one notification, where I list all the entries without files? Well, probably that's not a good idea, if there are many entries without files

Show it only, if NO ENTRY has a file attached. Then, it makes sense.

In all other cases, the other places of the JabRef UI guide the user.

InAnYan added a commit that referenced this issue Sep 4, 2024
@InAnYan
Fix for #166 and fix for #176
2c8650f
@InAnYan
Copy link
Owner

InAnYan commented Sep 4, 2024

Should be fixed

@InAnYan InAnYan added the status: waiting-for-feedback The submitter needs to recheck the issue or provide more information about the issue label Sep 4, 2024
@InAnYan
Copy link
Owner

InAnYan commented Sep 4, 2024

Show it only, if NO ENTRY has a file attached. Then, it makes sense.

Just in case, there is such functionality :)

@koppor
Copy link
Collaborator Author

koppor commented Sep 4, 2024

For dumb users, please also add a warning if no entries are there:

image

@koppor
Copy link
Collaborator Author

koppor commented Sep 4, 2024

No files: no error :-(

image

@koppor koppor removed the status: waiting-for-feedback The submitter needs to recheck the issue or provide more information about the issue label Sep 4, 2024
@InAnYan
Copy link
Owner

InAnYan commented Sep 4, 2024

sorry, I just was sure I made this for all AI chat component, but probably this feature is only available for entry chat

github-merge-queue bot pushed a commit to JabRef/jabref that referenced this issue Sep 4, 2024
@InAnYan @koppor
Chat with groups + AI chat UI and logic overhaul (#11666)
7f7726e 
* AI chat UI overhaul

* Chat history and AI chat overhaul

* Implement ingestion logic

* Implement ingestion logic

* Accept list of entries

* Group chat history logic

* Move components to folders and introduce AiPrivacyNoticeGuardedComponent

* Move components to folders and introduce AiPrivacyNoticeGuardedComponent

* Introduce EmbeddingModelGuardedComponent

* SummaryComponent overhaul

* Summarization logic overhaul

* Finish work on refactoring the summarization

* Introduce group chats

* Introduce group chat

* Refactor AI code

* AI chat UI overhaul

* Chat history and AI chat overhaul

* Implement ingestion logic

* Implement ingestion logic

* Accept list of entries

* Group chat history logic

* Move components to folders and introduce AiPrivacyNoticeGuardedComponent

* Move components to folders and introduce AiPrivacyNoticeGuardedComponent

* Introduce EmbeddingModelGuardedComponent

* SummaryComponent overhaul

* Summarization logic overhaul

* Finish work on refactoring the summarization

* Introduce group chats

* Introduce group chat

* Refactor AI code

* Fix GenerateEmbeddingsTask

* Introduce windows

* Refactor notifications

* No linting errors occurring

* Improve chat history component

* Discard changes to src/main/java/module-info.java

* Refine JavaDoc

* Fix for InAnYan#173

* Fix for InAnYan#171

* Fix from code review

* Fix checkers

* Fix for InAnYan#175 and InAnYan#174

* Follow-up for InAnYan#175

* Fix for InAnYan#166

* Fix for InAnYan#164

* Fix checkers

* Fix from code review

* Update src/main/java/org/jabref/gui/ai/components/aichat/AiChatGuardedComponent.java

Co-authored-by: Oliver Kopp <[email protected]>

* Fix for InAnYan#166 and fix for InAnYan#176

* Might be fix for InAnYan#178

* Migrate from AbstractGroup to GroupTreeNode

* Fix for InAnYan#170

* Fix for InAnYan#164

* InAnYan#177

* Fix for InAnYan#180

* Fix checkers

* Fix the system message

* Fix for InAnYan#180

* Fix context menu order

* Fix `startsWith`

* Fix system message

* Fix for ProgressCounter

* Fix for system message

---------

Co-authored-by: Oliver Kopp <[email protected]>
@koppor koppor added this to the Chat with a group of documents milestone Sep 4, 2024
@koppor koppor removed the groupchat label Sep 4, 2024
@koppor
Copy link
Collaborator Author

koppor commented Oct 13, 2024

Current behavior if no files are attached:

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Chat with a group of documents
Development

No branches or pull requests
2 participants
@koppor @InAnYan