Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ESC should close the window #180

Closed
koppor opened this issue Sep 4, 2024 · 2 comments
Closed

ESC should close the window #180

koppor opened this issue Sep 4, 2024 · 2 comments

Comments

@koppor
Copy link
Collaborator

koppor commented Sep 4, 2024

image

(not really sure about this - maybe discuss)

--> GEneral UI pattern of JabRef

Maybe also include developer documentation - UX checklist.

Larger one maybe

(If another user complains, immediately fix)

InAnYan added a commit that referenced this issue Sep 4, 2024
@koppor
Copy link
Collaborator Author

koppor commented Sep 4, 2024

Cannot open chat window any more after ESC.

InAnYan added a commit that referenced this issue Sep 4, 2024
@InAnYan
Copy link
Owner

InAnYan commented Sep 4, 2024

Pushed the fix :)

@InAnYan InAnYan added the status: waiting-for-feedback The submitter needs to recheck the issue or provide more information about the issue label Sep 4, 2024
@koppor koppor removed the status: waiting-for-feedback The submitter needs to recheck the issue or provide more information about the issue label Sep 4, 2024
@koppor koppor closed this as completed Sep 4, 2024
github-merge-queue bot pushed a commit to JabRef/jabref that referenced this issue Sep 4, 2024
* AI chat UI overhaul

* Chat history and AI chat overhaul

* Implement ingestion logic

* Implement ingestion logic

* Accept list of entries

* Group chat history logic

* Move components to folders and introduce AiPrivacyNoticeGuardedComponent

* Move components to folders and introduce AiPrivacyNoticeGuardedComponent

* Introduce EmbeddingModelGuardedComponent

* SummaryComponent overhaul

* Summarization logic overhaul

* Finish work on refactoring the summarization

* Introduce group chats

* Introduce group chat

* Refactor AI code

* AI chat UI overhaul

* Chat history and AI chat overhaul

* Implement ingestion logic

* Implement ingestion logic

* Accept list of entries

* Group chat history logic

* Move components to folders and introduce AiPrivacyNoticeGuardedComponent

* Move components to folders and introduce AiPrivacyNoticeGuardedComponent

* Introduce EmbeddingModelGuardedComponent

* SummaryComponent overhaul

* Summarization logic overhaul

* Finish work on refactoring the summarization

* Introduce group chats

* Introduce group chat

* Refactor AI code

* Fix GenerateEmbeddingsTask

* Introduce windows

* Refactor notifications

* No linting errors occurring

* Improve chat history component

* Discard changes to src/main/java/module-info.java

* Refine JavaDoc

* Fix for InAnYan#173

* Fix for InAnYan#171

* Fix from code review

* Fix checkers

* Fix for InAnYan#175 and InAnYan#174

* Follow-up for InAnYan#175

* Fix for InAnYan#166

* Fix for InAnYan#164

* Fix checkers

* Fix from code review

* Update src/main/java/org/jabref/gui/ai/components/aichat/AiChatGuardedComponent.java

Co-authored-by: Oliver Kopp <[email protected]>

* Fix for InAnYan#166 and fix for InAnYan#176

* Might be fix for InAnYan#178

* Migrate from AbstractGroup to GroupTreeNode

* Fix for InAnYan#170

* Fix for InAnYan#164

* InAnYan#177

* Fix for InAnYan#180

* Fix checkers

* Fix the system message

* Fix for InAnYan#180

* Fix context menu order

* Fix `startsWith`

* Fix system message

* Fix for ProgressCounter

* Fix for system message

---------

Co-authored-by: Oliver Kopp <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants