Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Shortcodes as variant text? #218

Open
Shelob9 opened this issue Jan 24, 2016 · 1 comment
Open

Shortcodes as variant text? #218

Shelob9 opened this issue Jan 24, 2016 · 1 comment
Assignees
@Shelob9
Labels
question
Milestone
1.3.2

Comments

@Shelob9
Copy link
Collaborator

Shelob9 commented Jan 24, 2016

Should definitely be a thing in destination tests, not sure in link/button...
@Shelob9 Shelob9 self-assigned this Jan 24, 2016
@Shelob9 Shelob9 added this to the 1.1.1 milestone Jan 24, 2016
Shelob9 added a commit that referenced this issue Jan 26, 2016
@Shelob9
Make it possible for a variant to be a short code. #218
a1fb51b
@Shelob9
Copy link
Collaborator Author

Shelob9 commented Jan 26, 2016

This is now possible if you add add_filter( 'ingot_click_test_content', 'do_shortcode' ); sometime before the Ingot test runs, generally at the_content I'm not ready to add this as a UI option as this is a bit of a can of worms given that it's not in the actual post content and many plugins load their JS/CSS conditionally based on seeing the shortcode in the content.

Shelob9 added a commit that referenced this issue Jan 26, 2016
@Shelob9
Merge branch '1.1.x-dev'
97369dc 
* 1.1.x-dev: (147 commits)
  tidying up pre-merge 1.1.0
  Make it possible for a variant to be a short code.  #218
  Make variant/group properties protected instead of private in click render class #229
  Page search for page destiantion tests #228
  Load trial mode if possible #226
  Fix destination description display #227
  Fix setting of variant from cookie #225
  Fixing invalid tests
  Fix switch to stats view #221
  Fix untranslatable string in stats view #224 #wtf
  Fix pulling/setting cookies for destination testing #222
  Don't track sessions if not front-end. #219
  Don't create sessions in admin/api requests #219
  Fix session setup #220
  better setting of variant property for destination tests, click test in general #214
  fix types labels/ orders #215
  Add hooks for licensing API request #212
  Filter to turn on and off admin script loading #210
  Add hooks in main UI markup #209
  Move admin markup to partial with filterable path #208
  ...

Conflicts:
	ingot.php
@Shelob9 Shelob9 modified the milestones: 1.1.1, 1.1.2 Feb 16, 2016
@Shelob9 Shelob9 modified the milestones: 1.2.1, 1.2.2 Mar 11, 2016
@Shelob9 Shelob9 modified the milestones: 1.3.1, 1.3.2 Jun 1, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Shelob9 Shelob9

Labels
question
Projects
None yet
Milestone
1.3.2
Development

No branches or pull requests
1 participant
@Shelob9