Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update oneMKL git tag to the latest version that support 2025 oneAPI. #2163

Open
sreerajkksd opened this issue Nov 11, 2024 · 0 comments
Open

Comments

@sreerajkksd
Copy link

Builds are failing when using current oneMKL from upstream when used in connection with intel oneAPI v2025.0.

The following fixes this:

> git diff
diff --git a/CMakeLists.txt b/CMakeLists.txt
index 5a5362ec51d..96a9bbdad70 100644
--- a/CMakeLists.txt
+++ b/CMakeLists.txt
@@ -117,7 +117,7 @@ if(_use_onemkl_interfaces)
     FetchContent_Declare(
             onemkl_interfaces_library
             GIT_REPOSITORY https://github.com/oneapi-src/oneMKL.git
-            GIT_TAG f2d2dcb4213a435bb60fbb88320c5f24892423ce
+            GIT_TAG 8f4312ef966420b9b8b4b82b9d5c22e2c91a1fe7
     )
     FetchContent_MakeAvailable(onemkl_interfaces_library)
     set(CMAKE_INSTALL_RPATH "${CMAKE_BINARY_DIR}/lib")

Is it only possible to add an additional option to use a local checkout directory of oneMKL instead ?

Use ONEMKL_INTERFACE_DIR=<localdir> cmake option and make the following changes:

> git diff
diff --git a/CMakeLists.txt b/CMakeLists.txt
index 5a5362ec51d..88219124009 100644
--- a/CMakeLists.txt
+++ b/CMakeLists.txt
@@ -114,11 +114,15 @@ if(_use_onemkl_interfaces)
         set(ENABLE_MKLGPU_BACKEND False)
         set(ENABLE_MKLCPU_BACKEND False)
     endif()
-    FetchContent_Declare(
-            onemkl_interfaces_library
-            GIT_REPOSITORY https://github.com/oneapi-src/oneMKL.git
-            GIT_TAG f2d2dcb4213a435bb60fbb88320c5f24892423ce
-    )
+    if(ONEMKL_INTERFACE_DIR)
+        FetchContent_Declare(onemkl_interfaces_library SOURCE_DIR "${ONEMKL_INTERFACE_DIR}")
+    else()
+        FetchContent_Declare(
+                onemkl_interfaces_library
+                GIT_REPOSITORY https://github.com/oneapi-src/oneMKL.git
+                GIT_TAG f2d2dcb4213a435bb60fbb88320c5f24892423ce
+        )
+    endif()
     FetchContent_MakeAvailable(onemkl_interfaces_library)
     set(CMAKE_INSTALL_RPATH "${CMAKE_BINARY_DIR}/lib")
 endif()

Is this change sensible ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant