Skip to content
This repository has been archived by the owner on Feb 2, 2024. It is now read-only.

Default value for skipna should be None or True when implementing methods in new style #233

Open
PokhodenkoSA opened this issue Oct 18, 2019 · 1 comment
Open

Default value for skipna should be None or True when implementing methods in new style #233

PokhodenkoSA opened this issue Oct 18, 2019 · 1 comment

Comments

@PokhodenkoSA
Copy link
Contributor

PokhodenkoSA commented Oct 18, 2019 •
edited
Loading

Are you sure that skipna=None here? It is better to refer to Pandas sources. We had am examples before where we found a bug in Pandas documentation

Originally posted by @shssf in #219
@PokhodenkoSA PokhodenkoSA mentioned this issue Oct 18, 2019
Merged
@PokhodenkoSA
Copy link
Contributor Author

The same discussions:
#227 (review).
#227 (comment)

My explanations why skipna should be None by default:
#227 (comment)
#227 (comment)

@PokhodenkoSA PokhodenkoSA mentioned this issue Oct 18, 2019
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@PokhodenkoSA