Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: don't attempt to write structure void blocks in minecraft structure #3092

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

PierreSchwang
Copy link
Member

Overview

Fixes #3090

Submitter Checklist

Preview Give feedback

@PierreSchwang PierreSchwang requested a review from a team as a code owner January 26, 2025 21:43
@github-actions github-actions bot added the Bugfix This PR fixes a bug label Jan 26, 2025
@@ -225,20 +225,20 @@ public void write(Clipboard clipboard) throws IOException {
// Blocks
LinListTag.Builder<@org.jetbrains.annotations.NotNull LinCompoundTag> blocks = LinListTag.builder(LinTagType.compoundTag());
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change this top javax while we're here I guess?

@dordsor21
Copy link
Member

Like I said on Discord, I wonder if it's an idea to add a switch to allow/disallow structure void to be pasted - I can see it being useful to know where they are

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bugfix This PR fixes a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Structure Voids are replaced with a placeholder (in structure schem)
3 participants