Initial changes to make GITFNS work with a personal GitHub repo. #1557
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It *really* doesn't like a local only repo!
The issue was incorrectly getting the ROOTFILENAME as where to attach the COPYRIGHT property.
…g-copyright-owner
…wner' into mth2--GITFNS-for-personal-repo
|
@MattHeffron, we talked about this in the technical meeting today. It isn't clear where this now stands, given the more recent changes in GITFNS. In particular, is this related to the problem that showed up in Maiko, where there are PRs based on repositories not owned by Interlisp? The current GITFNS recognizes that situation and prints a warning. It doesn't yet run the additional git commands to make them accessible, but that's on the list. If that is done, would it solve the problem that you were working on here? |
|
The situation these changes were made as a start to address was that I had a local git repository that was NOT on GitHub. The GITFNS seemed not to be able to deal with this kind of repository. As I recall, these edits handled some of the issues, but the dependency on using GH meant that some things couldn’t be addressed. (Pull requests are irrelevant for a local repo.) I don’t know what other issues I ran into, so I brute-force solved this by pushing this repo up to a private repo on GitHub.
I don’t know if any of my changes would be useful, in general, for GITFNS.
Matt
From: rmkaplan ***@***.***>
Sent: Monday, May 27, 2024 8:15 PM
To: Interlisp/medley ***@***.***>
Cc: Matt Heffron ***@***.***>; Mention ***@***.***>
Subject: Re: [Interlisp/medley] Initial changes to make GITFNS work with a personal GitHub repo. (PR #1557)
@MattHeffron <https://github.com/MattHeffron> , we talked about this in the technical meeting today. It isn't clear where this now stands, given the more recent changes in GITFNS. In particular, is this related to the problem that showed up in Maiko, where there are PRs based on repositories not owned by Interlisp? The current GITFNS recognizes that situation and prints a warning. It doesn't yet run the additional git commands to make them accessible, but that's on the list. If that is done, would it solve the problem that you were working on here?
—
Reply to this email directly, view it on GitHub <#1557 (comment)> , or unsubscribe <https://github.com/notifications/unsubscribe-auth/AB7BB4QYDLNCZIZG26X2VTTZEPZENAVCNFSM6AAAAABD3GH626VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMZUGI3TOMRYGE> .
You are receiving this because you were mentioned. <https://github.com/notifications/beacon/AB7BB4R642BNHFELQRRSOSLZEPZENA5CNFSM6AAAAABD3GH626WGG33NNVSW45C7OR4XAZNMJFZXG5LFINXW23LFNZ2KUY3PNVWWK3TUL5UWJTT7GZ6KC.gif> Message ID: ***@***.*** ***@***.***> >
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It still expects the repo to be on GitHub, but this seems to help a bit.