Add module for UTxO type and operations #710
Open
+92
−27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
locallycompact
requested review from
dcoutts,
Jimbo4350,
erikd,
newhoggy,
carbolymer,
smelc,
palas,
kevinhammond,
CarlosLopezDeLara and
disassembler
as code owners
carbolymer
reviewed
Dec 30, 2024
locallycompact
force-pushed
the
lc/utxo-module
branch
9 times, most recently
from
0ce0fcf to
a2dbc0a
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
locallycompact
force-pushed
the
lc/utxo-module
branch
2 times, most recently
from
a07f563 to
1e931e1
Compare
carbolymer
reviewed
Jan 7, 2025
carbolymer
reviewed
Jan 7, 2025
locallycompact
force-pushed
the
lc/utxo-module
branch
from
1e931e1 to
1235545
Compare
carbolymer
approved these changes
Jan 29, 2025
Jimbo4350
reviewed
Jan 29, 2025
| @@ -248,6 +250,7 @@ library | |||
| Cardano.Api.Ledger | |||
| Cardano.Api.Network | |||
| Cardano.Api.Shelley | |||
| Cardano.Api.UTxO | |||
There was a problem hiding this comment.
Keep this module hidden and expose the functionality from Cardano.Api. We need to do an audit on how we expose things.
There was a problem hiding this comment.
No. This module by design is intended to be imported qualified, similar to container modules such as Data.Map, as it contains function names which commonly conflict.
| @@ -0,0 +1,3 @@ | |||
| module Cardano.Api.UTxO (module Cardano.Api.Query.UTxO) where | |||
There was a problem hiding this comment.
These modules exposing modules generally are annoying. See my comment above as to how this functionality should be exposed for the time being.
There was a problem hiding this comment.
Also see above.
locallycompact
force-pushed
the
lc/utxo-module
branch
from
1235545 to
f6a3ba2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog
Context
Additional context for the PR goes here. If the PR fixes a particular issue please provide a link to the issue.
How to trust this PR
Highlight important bits of the PR that will make the review faster. If there are commands the reviewer can run to observe the new behavior, describe them.
Checklist