Clear out psbFromBytes, quasiquoter #294
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kozross
changed the title
kozross
changed the title
tdammers
requested changes
Aug 11, 2022
cardano-crypto-class/src/Cardano/Crypto/PinnedSizedBytes/Internal.hs
Outdated
Show resolved
Hide resolved
tdammers
reviewed
Aug 15, 2022
tdammers
reviewed
Aug 15, 2022
tdammers
reviewed
Aug 15, 2022
tdammers
requested changes
Aug 22, 2022
|
@tdammers - your comment has already been addressed a few commits ago. I can't reply to it, as it's marked 'outdated'. |
tdammers
approved these changes
Aug 25, 2022
lehins
requested changes
Aug 25, 2022
Comment on lines
+112
to
+118
| decodeAndCount chunk | ||
| | Text.length chunk /= 2 = do | ||
| len <- get | ||
| fail $ "Odd number of hexits (" <> show (2 * len + 1) <> ")." | ||
| | otherwise = case readMaybe ("0x" <> Text.unpack chunk) of | ||
| Nothing -> fail $ "Invalid hexit pair (" <> Text.unpack chunk <> ")." | ||
| Just w8 -> modify (+ 1) $> w8 |
There was a problem hiding this comment.
Why are you reimplementing from hex conversion? Why not just use base16-bytestring?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This attempts to resolve #291. In particular:
psbFromBytesare gone.IsString PinnedSizedBytesis gone.psbHexhas been added for compile-time construction.Some refactors to enable the quasiquoter have also been added.
Currently, I'm submitting this as a draft, as I can't (quite) figure out how to stop the quasiquoter making two identical hex strings constructPinnedSizedByteswhich share the same address. This is reproduced by one of the tests, which is currently failing. I attempted to address this by porting overprimitive'sLiftinstance forByteArray, but that doesn't seem to help any.Upon further attempts, I'm basically giving up on this, and leaving a note about not mutating the outcomes of the quasiquoter. This is basically for two reasons:
@lehins - tagging you for a review.