Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect Bech32 Prefix for script-based DReps #1848

Open
Ryun1 opened this issue Sep 5, 2024 · 2 comments
Open

Incorrect Bech32 Prefix for script-based DReps #1848

Ryun1 opened this issue Sep 5, 2024 · 2 comments
Labels
bug Something isn't working

Comments

@Ryun1
Copy link
Member

Ryun1 commented Sep 5, 2024

OS
Your OS: Unbuntu

Versions
The db-sync version (eg cardano-db-sync --version):
PostgreSQL version: 13.5.0.1

Build/Install Method
The method you use to build or install cardano-db-sync: binaries

Run method
The method you used to run cardano-db-sync (eg Nix/Docker/systemd/none):

Additional context

Problem Report

  • drep_hash table view does not reflect different bech32 prefix for script-based DReps
  • As per CIP-0005, script based DReps use the prefix of drep_script whereas key based DReps use just drep here
@rdlrt
Copy link

rdlrt commented Sep 5, 2024

The variations in representation is also one of the causes of #1835 request to atleast make bech32 fields optional (there is also draft CIP-105 and CIP-129, that hasnt been merged, but is already been adopted on toolsets mentioned on CIP - I dont expect dbsync to have to keep up with the off-chain formats, as repercussions are historical - and a change 4 years down the line would then require retrofitting fixes to existing records).

@Fell-x27
Copy link

Fell-x27 commented Oct 8, 2024

Also, we can build it manually with pg_cardano;

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants