Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

readProtocolParametersSourceSpec should be able to retrieve the ProtocolParameters by querying local node #5052

Open
1 task
carbolymer opened this issue Apr 4, 2023 · 3 comments · Fixed by #5053 · May be fixed by #5054
Open
1 task

readProtocolParametersSourceSpec should be able to retrieve the ProtocolParameters by querying local node #5052

carbolymer opened this issue Apr 4, 2023 · 3 comments · Fixed by #5053 · May be fixed by #5054
Assignees
@carbolymer
Labels
comp: cardano-cli Stale type: enhancement An improvement on the existing functionality type: internal feature Non user-facing functionality

Comments

@carbolymer
Copy link
Contributor

carbolymer commented Apr 4, 2023 •
edited
Loading

readProtocolParametersSourceSpec is supposed to derive a ProtocolParameters value from either JSON encoded ProtocolParameters file or a ShelleyGenesis file. The problem is the ProtocolParameters has had fields deprecated and added as we've transitioned between the eras. The scope of the change:

  1. Deprecate the option to derive the ProtocolParameters from the ShelleyGenesis as this is incorrect for the reason I gave above.
  2. In all instances where readProtocolParametersSourceSpec is used to generate a ProtocolParameters value, include the option to use the local state query protocol (i.e query the local node) to retrieve the current ProtocolParameters value.

Additional tasks:
@carbolymer carbolymer added type: enhancement An improvement on the existing functionality type: internal feature Non user-facing functionality comp: cardano-cli labels Apr 4, 2023
@carbolymer carbolymer self-assigned this Apr 4, 2023
carbolymer added a commit that referenced this issue Apr 4, 2023
@carbolymer
#5052 Deprecate reading protocol parameters from a file
9529de1
@carbolymer carbolymer mentioned this issue Apr 4, 2023
Merged
@carbolymer carbolymer changed the title readProtocolParametersSourceSpec should be able to retrieve the ProtocolParameters by querying local node readProtocolParametersSourceSpec should be able to retrieve the ProtocolParameters by querying local node Apr 4, 2023
carbolymer added a commit that referenced this issue Apr 4, 2023
@carbolymer
#5052 Add constructor for using local node
57d2cea
carbolymer added a commit that referenced this issue Apr 4, 2023
@carbolymer
#5052 Deprecate reading protocol parameters from a file
175db9d
This was linked to pull requests Apr 7, 2023
#5052 Remove reading protocol parameters from Shelley genesis file #5053
Merged
Add possibility to query local node to load protocol parameters - transaction build #5054
Draft
carbolymer added a commit that referenced this issue Apr 7, 2023
@carbolymer
#5052 Add constructor for using local node
890fc60
carbolymer added a commit that referenced this issue Apr 7, 2023
@carbolymer
#5052 Move params spec to Transaction module
bc0fc9e
carbolymer added a commit that referenced this issue Apr 7, 2023
@carbolymer
#5052 add additional CLI flags for querying the node
f346061
carbolymer added a commit that referenced this issue Apr 7, 2023
@carbolymer
#5052 Add parser for node params flag
158ddc6
carbolymer added a commit that referenced this issue Apr 7, 2023
@carbolymer
#5052 Add node querying for "transaction build" command
62079cf
carbolymer added a commit that referenced this issue Apr 7, 2023
@carbolymer
#5052 Add node querying for "transaction build" command
3b33373
@carbolymer carbolymer linked a pull request Apr 7, 2023 that will close this issue
Draft
carbolymer added a commit that referenced this issue Apr 11, 2023
@carbolymer
#5052 Remove ParamsFromGenesis option
c141b50
carbolymer added a commit that referenced this issue Apr 11, 2023
@carbolymer
#5052 Remove reading parameters from shelley genesis file
35346b0
@carbolymer
Copy link
Contributor Author

carbolymer commented Apr 12, 2023 •
edited
Loading

@Jimbo4350 seems that --protocol-params-file is deprecated - at least that warning says that: https://github.com/input-output-hk/cardano-node/blob/master/cardano-cli/src/Cardano/CLI/Shelley/Run/Transaction.hs#L651-L655
Should we do anything about that warning / flag within the scope of this issue?
(thanks @newhoggy for pointing that out)

carbolymer added a commit that referenced this issue Apr 12, 2023
@carbolymer
#5052 Update changelog about breaking change
a3e6db8
@gitmachtl
Copy link
Contributor

#5053 (comment)

carbolymer added a commit that referenced this issue Apr 14, 2023
@carbolymer
Merge pull request #5053 from input-output-hk/mgalazyn/feature/deprec…
363fc0f 
…ate-protocol-params-file

#5052 Remove reading protocol parameters from Shelley genesis file
@carbolymer carbolymer reopened this Apr 14, 2023
carbolymer added a commit that referenced this issue Apr 14, 2023
@carbolymer
#5052 Add parser for node params flag
2713502
carbolymer added a commit that referenced this issue Apr 14, 2023
@carbolymer
#5052 Add parser for node params flag
6044cc2
@github-actions
Copy link

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 120 days.

@github-actions github-actions bot added the Stale label May 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@carbolymer carbolymer

Labels
comp: cardano-cli Stale type: enhancement An improvement on the existing functionality type: internal feature Non user-facing functionality
Projects
None yet
Milestone
No milestone
2 participants
@carbolymer @gitmachtl