Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Eliminate boolean properties #342

Closed
1 of 4 tasks
WhatisRT opened this issue Dec 19, 2023 · 0 comments · Fixed by #649
Closed
1 of 4 tasks

Eliminate boolean properties #342

WhatisRT opened this issue Dec 19, 2023 · 0 comments · Fixed by #649
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@WhatisRT
Copy link
Collaborator

WhatisRT commented Dec 19, 2023

For convenience or other reasons, some properties/predicates produce booleans. Our properties should always go to Set, so we can use them without writing something like ≡ true.

Here are some offenders:

  • actionWellFormed
  • isP2Script
  • isAdaOnlyᵇ
  • feesOK

delayingAction is an exception, since we use this to update an actual Bool in a state.

@WhatisRT WhatisRT added enhancement New feature or request good first issue Good for newcomers labels Dec 19, 2023
@carlostome carlostome linked a pull request Jan 23, 2025 that will close this issue
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant