-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 Incomplete Listing of Active dReps in Govtool #2187
Comments
It's a feature 😄 |
@jdyczka , if that's the case, how can I view the list of direct voters? I think it would be ideal to display direct voters in the dRep directory, with an option to filter by direct voters, alongside other filters like active, inactive, and retired dReps. What do you think? Where would you suggest displaying the list of direct voters, @m-i-k-e ?
|
@kneerose As for fetching only active DReps by default, I agree that it seems like a good idea. Although, I'm not sure when the DRep becomes inactive. If it happens after a relatively short period maybe we should include them by default after all. I personally feel like I don't know enough about how users use GovTool or how we want them to use it, so certainly @m-i-k-e is a better person to answer this question, but here is how I understand the logic behind this decision. From a technical standpoint there is no distinction between DReps and Direct Voters. Direct Voters are essentially DReps without metadata. As I understand the main purpose of DRep Directory is for the user to find a representative for themselves to delegate their voting power to. In that case it makes sense to only show DReps who have the metadata which tells the user what they can expect from that DRep. |
That is specified in epoch params |
Area
Other
Domain
gov.tools
Which wallet were you using?
No response
Context
The dRep directory in Govtool is not displaying all active dReps. According to Adastat API, there are 485 active dReps, but only 262 are shown in Govtool.
But if I search for a dRep that is not listed on the active dRep list in Govtool, it will still return a response. For example,
drep1000002hneyj7jl9y95m0zxdsg6dp9n9y59lvlm7xjqp4qh2jx7h
is not on the active dRep list, but when I search for it, it shows a response.Steps to reproduce
Actual behavior
The list in Govtool only shows 262 active dReps, missing several entries that are present in the Adastat data.
Expected behavior
The Govtool should display all active dReps in the directory
Possible Reason
These might be the reason for not listed all active dReps on dRep list
It would be better to compare drep_hash and drep_registration rather than drep_hash and drep_distr table
Possible solution
drep_registration.drep_hash_id
instead ofdrep_distr.hash_id
Additional Details:
The text was updated successfully, but these errors were encountered: