Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Wrong voting power numbers for retired dReps #2774

Open
MadOrkestra opened this issue Jan 27, 2025 · 4 comments
Open

🐛 Wrong voting power numbers for retired dReps #2774

MadOrkestra opened this issue Jan 27, 2025 · 4 comments
Labels
🐛 Bug Something isn't working Other area

Comments

@MadOrkestra
Copy link

Area

Other

Domain

gov.tools

Which wallet were you using?

No response

Context

I was just scrolling through the dRep directory and was kinda mind blown by the amount of retired dReps with active delegation. Turns out: the displayed data is dead wrong though, there are only 3 retired dReps with active delegation.

Probably a missing cronjob that updates delegation even for retired dReps?

(I'd suggest a little UI tweak anyways: show retired dReps only if actively selected, they are of no interest if you browse the dRep Directory to find a dRep to delegate to...)

Steps to reproduce

  1. Go to https://gov.tools/drep_directory
  2. Look for retired dReps
  3. Check their delegation
  4. Find the displayed amounts are wrong

Actual behavior

Wrong / outdated (?) delegation amounts / voting power is shown.

Expected behavior

Display correct voting power, even for retired dReps.

@MadOrkestra
Copy link
Author

Might be correct after all... because we have the same issue as with delegation to retired stake pools. Technically that ADA isn't staked anymore, but as stake or voting delegation doesn't "fall back" to some default option, it could also be shown as still with that stake pool / dRep?

@bosko-m
Copy link
Contributor

bosko-m commented Feb 3, 2025

This is actually a great catch @MadOrkestra .
@l-br1 @MSzalowski @Ryun1 what do you think?

@Ryun1
Copy link
Member

Ryun1 commented Feb 3, 2025

It does seem weird that we show retired DReps via the directory, good call @MadOrkestra

it could also be shown as still with that stake pool / dRep?

I do quite like this as it could be good info to be able to remind people to re-delegate

Maybe the retired DReps are just hidden by a default filter?

@l-br1
Copy link

l-br1 commented Feb 4, 2025

so in theory, retired DReps were not supposed to be shown in the list BUT if you originally delegated to a DRep now retired you should have still see it on the top of the page (exactly for the reason mentioned by @MadOrkestra, to remind them to redelegate)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 Bug Something isn't working Other area
Projects
Status: No status
Status: No status
Development

No branches or pull requests

4 participants