Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

db-synthesizer does not use ExperimentalHardForksEnabled option #1072

Open
RenateEilers opened this issue Apr 22, 2024 · 1 comment
Open
Assignees

Comments

@RenateEilers
Copy link
Contributor

RenateEilers commented Apr 22, 2024

Summary

In #4341 TestEnableDevelopmentHardForkEras has been renamed to ExperimentalHardForksEnabled for cardano-node, but the configuration parser for db-synthesizer hasn't seen this change. As a result, calling db-synthesizer with a configuration file where the option is renamed results in behavior that is different from calling cardano-node with the same config. This unintuitive difference can lead to problems (see e.g. #1071) and time-consuming investigations.

Completion criteria
db-synthesizer displays the expected behavior when ExperimentalHardForksEnabled is enabled.

The ideal path to this solution is to separate out the parts of cardano-node and ouroboros-consensus that read node configuration in favor of a shared component. This will prevent any future divergence.

If investigation shows that such a separation would require an unreasonable restrucuring of the current code, it will suffice to update the parsers in ouroboros-consensus to match cardano-node.

@RenateEilers RenateEilers changed the title db-synthesizer does not use the ExperimentalHardForksEnabled option db-synthesizer does not use ExperimentalHardForksEnabled option Apr 22, 2024
@RenateEilers RenateEilers self-assigned this Apr 22, 2024
@amesgen
Copy link
Member

amesgen commented Jul 2, 2024

FTR: With #1173 merged, db-synthesizer will "understand" Conway by default.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants