Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Edp Native Inspiration Gallery Upload (reflect stage) #1815

Closed
James-Robe opened this issue Apr 24, 2018 · 2 comments
Closed

Edp Native Inspiration Gallery Upload (reflect stage) #1815

James-Robe opened this issue Apr 24, 2018 · 2 comments

Comments

@James-Robe
Copy link

James-Robe commented Apr 24, 2018

resulting from #1808

When the user clicks "upload to the inspiration gallery" on the reflect stage page (there should be a button on the congrats box and a link in the reflect / feedback box, see #1816 and #1811 ) they should be prompted with the same upload window they would see on the inspiration gallery page.

fireshot capture 28 - construct a crane i c_ - http___127 0 0 1_8000_challenges_2_studentj1_reflect_
fireshot capture 29 - construct a crane i c_ - http___127 0 0 1_8000_challenges_2_studentj1_reflect_
xvaandr

[ ] Question: perhaps it would be best after the submission is made, to change the link/button to direct the user TO the inspiration gallery.

@James-Robe James-Robe added the 3 - Iteration Backlog To do in the current iteration label Apr 24, 2018
@James-Robe James-Robe self-assigned this Apr 24, 2018
James-Robe added a commit that referenced this issue Apr 25, 2018
Work for #1816 additionally, I removed the avatar and center column for the layout. Remaining work: inspiration button needs to change once the native inspiration gallery upload feature is added ( #1815 )
@James-Robe James-Robe added 4 - In Progress and removed 3 - Iteration Backlog To do in the current iteration labels Apr 30, 2018
@stenington stenington added this to the AIFC Stage 2 Start milestone May 4, 2018
@stenington
Copy link

@James-Robe add some notes here and close

@stenington
Copy link

@James-Robe talked about how uploading to the inspiration gallery when that concept hadn't been introduced yet to a user in the EDP felt strange, so linking to the gallery where they can see what it is first seems better after having worked on this a bit.

stenington pushed a commit that referenced this issue May 15, 2018
Work for #1816 additionally, I removed the avatar and center column for the layout. Remaining work: inspiration button needs to change once the native inspiration gallery upload feature is added ( #1815 )
stenington added a commit that referenced this issue May 15, 2018
* 1816 Moved the congrats box to right column

Work for #1816 additionally, I removed the avatar and center column for the layout. Remaining work: inspiration button needs to change once the native inspiration gallery upload feature is added ( #1815 )

* 1817 nav bar updates

the nav bar and header portion of #1817

* #1817 comment "timeline" changes

This handles the comment formatting changes outlined in #1817

* #1811 edp comment box styling

impliments the vartious styling changes in #1811

* removed unnecessary css

* removed middle panel and simplified negative margin

* fixed spacing

* removed under nav header

* updated "test" step description

* corrected an accidental code commit

This should be a link

* updated plan and build templates

removed the plan stage build call to action and the hardcoded testing phrase in the build stage.

* remove non utf-8 character
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants