Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: Svelte 4 support #302

Closed
JeviScript opened this issue Jul 1, 2023 · 13 comments · Fixed by #309
Closed

Feature request: Svelte 4 support #302

JeviScript opened this issue Jul 1, 2023 · 13 comments · Fixed by #309

Comments

@JeviScript
Copy link

JeviScript commented Jul 1, 2023

Hey! Just wanted to ask if there is a plan to update the lib to support Svelte 4? As it stands it does not compile for Svelte 4 giving typescript errors when using wrap function. Current workaround is typecast it like so:

  const routes = {
    "/home": wrap({
      asyncComponent: () => import("./routes/Home.svelte") as Promise<{default: typeof SvelteComponent}>,
}
@mikeychowy
Copy link

mikeychowy commented Jul 2, 2023

I'll maybe open a PR for svelte 4 support when I have the time, the migration script should be doing all the heavy lifting so it'll be a quick update

@ItalyPaleAle
Copy link
Owner

👋 I think we definitely do want svelte 4 support.

I will not be able to look into this until next weekend at the earliest. But I welcome any PR!

It may be a good opportunity to also go through with some breaking changes.

@mikeychowy
Copy link

created a PR here

@laoshaw
Copy link

laoshaw commented Sep 3, 2023

When will this be merged? this project is what made me to stay with Svelte, I don't like sveltekit's SSR-first approach as I only need CSR SPA for all my projects, as I can not run node.js(SSR) on my boards due to hardware resource constraints. Thanks.

@boustanihani
Copy link

Please merge and support Svelte-4.

Svelte-5 is also on its way :)

@DirkRaeder-KDO
Copy link

@ItalyPaleAle any update on this?

@ItalyPaleAle
Copy link
Owner

@mikeychowy are you still planning on working on this?

@doregex
Copy link

doregex commented Nov 14, 2023

I might look into it on Thursday or Friday to perform the @mikeychowy changes without the linter to support svelte4.

@ItalyPaleAle hai tempo di darci un occhio nel weekend nel caso?

@carbogninalberto
Copy link
Collaborator

carbogninalberto commented Nov 22, 2023

I opened the PR #309 bumping the changes from @mikeychowy
I tried to build the test app and it's working, but I am unsure of how to run the automated tests

@carbogninalberto
Copy link
Collaborator

@ItalyPaleAle did you have time to take a look?

@ItalyPaleAle
Copy link
Owner

@ItalyPaleAle did you have time to take a look?

Thanks for the PR! I will get it merged later today. Right now the CI is broken and I'll have to fix that first.

Expect a release in about 24 hours

@ItalyPaleAle
Copy link
Owner

Thanks @carbogninalberto for the PR. I fixed the linter issues and merged it.

I am going to do some additional validation tomorrow and then cut the release

@ItalyPaleAle
Copy link
Owner

Version 4.0.0 has been released with Svelte 4 support!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

8 participants