Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements #3

Open
diimdeep opened this issue Dec 3, 2021 · 1 comment
Open

Improvements #3

diimdeep opened this issue Dec 3, 2021 · 1 comment

Comments

@diimdeep
Copy link

diimdeep commented Dec 3, 2021

Hello. Very well done, I like this clever implementation by using input methods;

A few things that bother me:

  1. There is already a new version(v14), might make sense to automate emojiStore.txt creation, from somewhere. https://unicode.org/Public/emoji/14.0/emoji-test.txt

  2. Might be good idea to add synonym search, there is another picker https://github.com/alirawashdeh/surf/
    It supports more keywords per emoji, with help of these https://github.com/alirawashdeh/emoji-list-fetcher + https://github.com/alirawashdeh/emoji-data-enricher

Just a few links.
https://unicode.org/Public/emoji/14.0/emoji-test.txt
https://unicode.org/emoji/charts-14.0/full-emoji-list.html
https://unicode.org/emoji/charts/emoji-list.html

@Jacky-He
Copy link
Owner

Jacky-He commented Dec 8, 2021

Hey, thanks a lot for checking this out! Yeah, I think automating emojiStore.txt creation would definitely be useful, and maybe I can also add more keyword search on top of the existing subsequence search as you suggested.

I'll try to work on those next. Also feel free to play round with the code and make a pull request at any point as you wish!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants