Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor project structure #156

Open
JafarAkhondali opened this issue Jun 12, 2024 · 0 comments
Open

Refactor project structure #156

JafarAkhondali opened this issue Jun 12, 2024 · 0 comments
Labels
enhancement New feature or request help wanted Extra attention is needed important

Comments

@JafarAkhondali
Copy link
Owner

I created this project only because Linux kernel didn't accept the RGB functionality as it wasn't standard, but it got more attention than I expected. The project designed like this:

  1. Cloned (~2021) the acer-wmi.c file from Linux kernel: https://github.com/torvalds/linux/blob/master/drivers/platform/x86/acer-wmi.c
  2. Modified the driver to support RGB and turbo
  3. Then on installation, the installer unload the acer driver(acer-wmi) and installs this driver(facer)

Main issues with this approach is:

  1. This project doesn't receive updates from Linux kernel
  2. It's harder to extract parts of this code to be used in Linux kernel

For example, fan control is now in progress to be merged in Linux kernel by other people:
#152

But we can't use that.

There are two things we can do, as baby steps:

  1. Sync facer.c with https://github.com/torvalds/linux/blob/master/drivers/platform/x86/acer-wmi.c to have latest features
  2. Instead of cloning whole code, save the implemented features as patch files(this makes some issues with contributions but I have no other ideas how to properly stay up to date with kernel upstream for a single file).

More help is required for this part.

@JafarAkhondali JafarAkhondali added enhancement New feature or request help wanted Extra attention is needed important labels Jun 12, 2024
@JafarAkhondali JafarAkhondali pinned this issue Jun 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed important
Projects
None yet
Development

No branches or pull requests

1 participant