Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Pad Missing Values #17

Merged
merged 11 commits into from
Mar 3, 2024
Merged

[Feature] Pad Missing Values #17

merged 11 commits into from
Mar 3, 2024

Conversation

JamesHWade
Copy link
Owner

  • Adds an optional argument to step_measure_input_long() to pad the measures in cases of missing values.
  • Checks for missing values in values column for step_measure_output_wide() to prevent a value of missing columns for cases where pad = TRUE in step_measure_input_long()
  • Cleanup tests and snapshots accordingly
  • Updates CI workflows

@JamesHWade JamesHWade added the enhancement New feature or request label Feb 2, 2024
@JamesHWade
Copy link
Owner Author

@topepo, I could use a second pair of eyes on these changes if you have the time. The intention was to add padding for users if they select pad = TRUE in step_measure_input_long().

PS - I'm back from parental leave, so I should have a lot more time to work on the package. Thanks for all your contributions so far!!!

@topepo
Copy link
Collaborator

topepo commented Feb 18, 2024

I'll take a look at it.

I was thinking of something that might be related and added comments to #16 . If we had a vector class, it would make (hopefully fast) methods to go between the current data structure and a more rectangular structure that seems to be required for some packages that we could leverage.

Anyway, we don't have that right now so I'll review this as-is.

@JamesHWade
Copy link
Owner Author

I'm going to go ahead and merge this in favor so to go ahead and get started on the vector class.

@JamesHWade JamesHWade merged commit cdc7b5a into main Mar 3, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants