Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Harden the scrot binary #2066

Open
txtsd opened this issue Oct 22, 2023 · 2 comments
Open

Harden the scrot binary #2066

txtsd opened this issue Oct 22, 2023 · 2 comments

Comments

@txtsd
Copy link

txtsd commented Oct 22, 2023

Detailed description of your suggestion

λ checksec --file=opt/blockbench/resources/app.asar.unpacked/node_modules/electron-color-picker/library/linux/linux-scrot/scrot
RELRO           STACK CANARY      NX            PIE             RPATH      RUNPATH	Symbols		FORTIFY	Fortified	Fortifiable	FILE
Partial RELRO   Canary found      NX enabled    No PIE          No RPATH   No RUNPATH   No Symbols	 Yes	7		9		opt/blockbench/resources/app.asar.unpacked/node_modules/electron-color-picker/library/linux/linux-scrot/scrot

The scrot binary currently lacks FULL RELRO and is not built with PIE.

Please make it so that this binary is built with sufficient hardening.

@JannisX11
Copy link
Owner

I don't know what most of these words mean, I am not a Linux person. This is just a dependency for the screen space color picker that is not owned by me and does not seem to be actively maintained. Does doing suggestion have any practical advantages?

@txtsd
Copy link
Author

txtsd commented May 10, 2024

Hardening binaries is basically reducing the ways in which your system can be attacked.

This binary seems to come from npmjs.com/package/electron-color-picker so there's no way to harden it. Hardening is done during compilation.

We could remove the dependency instead, as suggested in #2187.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants