Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(jans-cedarling): relax JwtService validation to allow optional claims #10060

Open
5 tasks
rmarinn opened this issue Nov 6, 2024 · 0 comments
Open
5 tasks
Assignees
Labels
comp-jans-cedarling Touching folder /jans-cedarling enhancement kind-feature Issue or PR is a new feature request
Milestone

Comments

@rmarinn
Copy link
Contributor

rmarinn commented Nov 6, 2024

Is your feature request related to a problem? Please describe.

The current validation in JwtService is overly strict, requiring fields that may not be present in all token scenarios. This can prevent certain tokens from being accepted even when they are otherwise valid for Cedarling's purposes. We need more flexibility to allow for tokens that might be missing some non-essential claims.

Describe the solution you'd like

  • iss should be OPTIONAL
  • aud should be OPTIONAL
  • sub should be OPTIONAL
  • exp should be OPTIONAL but check validity if there is one
  • nbf should be OPTIONAL but check validity if there is one
@rmarinn rmarinn added comp-jans-cedarling Touching folder /jans-cedarling enhancement labels Nov 6, 2024
@rmarinn rmarinn self-assigned this Nov 6, 2024
@mo-auto mo-auto added the kind-feature Issue or PR is a new feature request label Nov 6, 2024
@moabu moabu added this to the 1.1.6 milestone Nov 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp-jans-cedarling Touching folder /jans-cedarling enhancement kind-feature Issue or PR is a new feature request
Projects
None yet
Development

When branches are created from issues, their pull requests are automatically linked.

3 participants