Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(docs): add Cedarling quick start guide and binding type documents #10906

Merged
merged 8 commits into from
Feb 26, 2025

Conversation

ossdhaval
Copy link
Contributor

No description provided.

@ossdhaval ossdhaval self-assigned this Feb 20, 2025
@mo-auto mo-auto added area-documentation Documentation needs to change as part of issue or PR comp-docs Touching folder /docs kind-bug Issue or PR is a bug in existing functionality labels Feb 20, 2025
@ossdhaval ossdhaval enabled auto-merge (squash) February 20, 2025 11:52
manojs1978
manojs1978 previously approved these changes Feb 20, 2025
Copy link
Contributor

@SafinWasi SafinWasi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small formatting mistake in the cedarling install command; everything else looks good to me.


1. Sign in to Agama Lab using your GitHub account and click on Policy Designer.
![image](../assets/cedarling-policy-designer.png)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Broken link
image

Comment on lines 185 to 189

```
pip install cedarling_python-0.0.0-cp310-cp310-manylinux_2_31_x86_64.whl
```
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The command should be

poetry run cedarling_python-0.0.0-cp310-cp310-manylinux_2_31_x86_64.whl

@ossdhaval ossdhaval requested a review from nynymike February 26, 2025 17:55
nynymike
nynymike previously approved these changes Feb 26, 2025
Copy link
Contributor

@SafinWasi SafinWasi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Due to Agama Lab changing the default namespace to Jans, we will need to make some changes. I can handle that here: #10950

@SafinWasi SafinWasi requested a review from nynymike February 26, 2025 18:08
@ossdhaval ossdhaval requested a review from mzico February 26, 2025 18:09
@ossdhaval ossdhaval merged commit bc0686f into main Feb 26, 2025
3 checks passed
@ossdhaval ossdhaval deleted the docs-cedarling-add-content branch February 26, 2025 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-documentation Documentation needs to change as part of issue or PR comp-docs Touching folder /docs kind-bug Issue or PR is a bug in existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants