Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

async-pidfd -> async_process #52

Closed
MaxVerevkin opened this issue Apr 29, 2024 · 4 comments · Fixed by #54
Closed

async-pidfd -> async_process #52

MaxVerevkin opened this issue Apr 29, 2024 · 4 comments · Fixed by #54

Comments

@MaxVerevkin
Copy link
Contributor

async-pidfd is unmaintained and pulls the async-io v1 dependency, while the main project depends on v2.
@JayceFayne
Copy link
Owner

JayceFayne commented Apr 30, 2024 •
edited
Loading

That's unfortunate. I see you opened a PR joshtriplett/async-pidfd#4, would be nice if it was merged...irrc I initially used async-process but switched to async-pidfd because it has less dependencies

@JayceFayne
Copy link
Owner

@MaxVerevkin maybe we should fork async-pidfd?

@MaxVerevkin
Copy link
Contributor Author

I can publish my fork so you can switch over to it, if that's what you mean.

@JayceFayne
Copy link
Owner

Yeah

@MaxVerevkin MaxVerevkin mentioned this issue Jul 3, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

switch to async-pidfd-next MaxVerevkin/swayipc-rs
2 participants
@JayceFayne @MaxVerevkin