Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: Compiling JANA as a CMake subproject #216

Open
DraTeots opened this issue Mar 28, 2023 · 3 comments
Open

Feature request: Compiling JANA as a CMake subproject #216

DraTeots opened this issue Mar 28, 2023 · 3 comments
Assignees

Comments

@DraTeots
Copy link
Collaborator

Currently JANA2 uses CMAKE_XXX where it should use CMAKE_CURRENT_XXX. As CMAKE_XXX is now corresponds to a parent CMake project.

@DraTeots DraTeots self-assigned this Mar 28, 2023
@nathanwbrei
Copy link
Collaborator

@DraTeots I gather we have to change all of our references to CMAKE_SOURCE_DIR to CMAKE_CURRENT_SOURCE_DIR. Any other variables that you know need to be changed?

I'm assuming that CMAKE_INSTALL_PREFIX,CMAKE_BUILD_TYPE,CMAKE_CXX_*, etc, should inherit from the parent project.

@DraTeots
Copy link
Collaborator Author

@nathanwbrei if you put a PR with that I can test and we'll figure out if there is something else

nathanwbrei added a commit that referenced this issue Oct 13, 2023
This should help JANA compile as a subproject (See issue #216)
@nathanwbrei
Copy link
Collaborator

@DraTeots Are you compiling JANA2 as a CMake subproject? If it works I'd like to close the issue.

@nathanwbrei nathanwbrei changed the title Make JANA2 configure and compile is used as CMake subproject Feature request: Compiling JANA as a CMake subproject Jul 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants