Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SetDefaultParameter mangles strings with whitespaces #217

Closed
veprbl opened this issue Mar 28, 2023 · 2 comments
Closed

SetDefaultParameter mangles strings with whitespaces #217

veprbl opened this issue Mar 28, 2023 · 2 comments

Comments

@veprbl
Copy link
Contributor

veprbl commented Mar 28, 2023

In EICrecon, we end up having to implement workarounds like eic/EICrecon#575, and those are only possible because our problem allows for strings without spaces to be interpreted correctly.

@faustus123
Copy link
Collaborator

I am unable to track this down fully right now so just writing some notes:

This was brought up previously in eic/EICrecon PR 472 and was addressed in PR #191 .

It should be getting checked with the test here:

It's not clear what is different in EICrecon from the JANA test so will need to be tracked down starting with a reproducing example from there.

@AyanRoy16
Copy link
Collaborator

Hello @wdconinc ,

We added the test case that shows that a c++ command is correctly parsed when provided as a string input to JParameter. Let me know if there is something that we are missing.
PR: #248
cc. @nathanwbrei @faustus123

nathanwbrei added a commit that referenced this issue Oct 9, 2023
…strings_with_whitespaces

Address issue #217: Test JParameterManager handling of strings containing whitespace
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants