Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

qa-physics: bin QA by scaler readouts, not 5-files #49

Closed
c-dilks opened this issue May 25, 2023 · 0 comments · Fixed by #111
Closed

qa-physics: bin QA by scaler readouts, not 5-files #49

c-dilks opened this issue May 25, 2023 · 0 comments · Fixed by #111
Assignees
Milestone

Comments

@c-dilks
Copy link
Member

c-dilks commented May 25, 2023

Perform the physics QA in sets ("bins") of consecutive events between a number of scaler readouts. This number may be run-period dependent, and could be chosen such that the QA bin size is similar to our current DST 5-file size.

This would resolve JeffersonLab/clas12-qadb#9 and return a more accurate calculation of accumulated FC charge per QA bin.

This would not be a breaking change to users, since they query the QADB by event number.

We could also do away with the deprecated binning by event numbers idea (see skim option of monitorRead.groovy)

@c-dilks c-dilks self-assigned this May 25, 2023
@c-dilks c-dilks added this to the Pass 2 milestone Sep 11, 2023
@c-dilks c-dilks linked a pull request Sep 14, 2023 that will close this issue
@c-dilks c-dilks moved this from Todo to In Progress in CLAS12 Timelines Sep 14, 2023
@github-project-automation github-project-automation bot moved this from In Progress to Done in CLAS12 Timelines Feb 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

1 participant