Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AHDC pulse id is used to set indices in adc bank but its value is never set #483

Closed
raffaelladevita opened this issue Feb 21, 2025 · 2 comments
Closed

AHDC pulse id is used to set indices in adc bank but its value is never set #483

raffaelladevita opened this issue Feb 21, 2025 · 2 comments
Assignees
@ftouchte

Comments

@raffaelladevita
Copy link
Collaborator

coatjava/common-tools/clas-detector/src/main/java/org/jlab/detector/pulse/ModeAHDC.java

Line 296 in 141e407

copyIndices(wfBank, adcBank, pulses.get(i).id, i);

@raffaelladevita raffaelladevita mentioned this issue Feb 21, 2025
Merged
@ftouchte
Copy link
Collaborator

I have fixed the issue. JeffersonLab/coatjava#480

@baltzell
Copy link
Collaborator

Closed by #480 . But, looks like Pulse just shouldn't provide an empty constructor ...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ftouchte ftouchte

Labels
None yet
Projects
ALERT Software Roadmap
Status: Done
Milestone
No milestone
Development

No branches or pull requests
3 participants
@baltzell @raffaelladevita @ftouchte