Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Templated VQwSubsystemParity for Sum, Difference, Ratio to use T::operator+, T::operator- etc #66

Open
wdconinc opened this issue Feb 1, 2019 · 0 comments
Assignees

Comments

@wdconinc
Copy link
Member

wdconinc commented Feb 1, 2019

Is your feature request related to a problem? Please describe.
There are a lot of redundant implementations of VQwSubsystemParity::Sum,Different,Ratio in the derived classes.

virtual void Sum(VQwSubsystem *value1, VQwSubsystem *value2) = 0;

A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]
I'm always frustrated, but that's neither here nor there.

Describe the solution you'd like
These are not necessary if we inherit from e.g. VQwSubsystemParity and define

virtual void Sum(T* value1, T* value2) { *this = *value1; *this += *value2; }
//etc

Describe alternatives you've considered
Status quo is always an alternative.

@wdconinc wdconinc assigned wdconinc and paulmking and unassigned wdconinc Feb 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants