Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Have you planned to manage versionName too ? #11

Open
cyrillekrasinski opened this issue Apr 24, 2018 · 2 comments
Open

Have you planned to manage versionName too ? #11

cyrillekrasinski opened this issue Apr 24, 2018 · 2 comments

Comments

@cyrillekrasinski
Copy link

Hi, I've just tested your plugin and the management of flavours is great for our project.
Have you planned to upgrade the plugin to add a method to increment the versionName too ?
It will be great to be able to update the versionName attribute with patch, minor or major option to increment the version (2.0.0=>2.0.1 for a patch, 2.0.0=>2.1.0 for a minor and 2.0.0 => 3.0.0 for a major).

Another plugin exists to update this version name but it does not support flavour and my issue has not been treated.

@engi2nee
Copy link

engi2nee commented Feb 1, 2019

@cyrillekrasinski may I know how were you able to manage the flavors for it?
I can see that there is a field called ext_constant_name that is supposed to help define the flavor.
This plugin is missing documentation, can you show an example of your Fastfile and the gradle that uses flavors ?

@oklimberg
Copy link
Collaborator

Would you call this plugin manually to set the versionName?
Setting the marketing version aka versionName seems to be a task, which only needs to be executes one in a while and not on every build.
Do you have a usecase, where this feature would be handy?

And I guess, if I decide to implement this, it might be a standalone plugin.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants