Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better Notification When Docker Daemon is not started #262

Open
khalidabuhakmeh opened this issue Oct 2, 2024 · 2 comments
Open

Better Notification When Docker Daemon is not started #262

khalidabuhakmeh opened this issue Oct 2, 2024 · 2 comments
Labels
feature New feature or request

Comments

@khalidabuhakmeh
Copy link

Describe the bug

Folks might have turned off their Docker Daemon and tried to start the Aspire App Host with container integrations, leading to a "quiet" failure. Only after going to the Services window do folks see the failure in the output.

To Reproduce
Steps to reproduce the behavior:

  1. Turn off Docker Daemon
  2. Attempt to start the AppHost run configuration
  3. Quiet failure
  4. See error

Expected behavior

Expect Rider to notify me/check that the Docker Daemon is required and not running. There are several options for UI/UX here.

  1. Wait for a fail message in the output and report that to users
  2. Check the Docker Daemon before running the run configuration

Screenshots

image001131-2024-10-02 -09-02-11

@khalidabuhakmeh khalidabuhakmeh added the bug Something isn't working label Oct 2, 2024
@rafaelldi rafaelldi added feature New feature or request and removed bug Something isn't working labels Oct 3, 2024
@rafaelldi
Copy link
Collaborator

I'm not sure about this. Tbh, DCP doesn't give us any information about containers, only about .NET projects. Obviously we can parse the source code and build the same model ourselves, but that might take a lot of work. Also, we can't always tell if Docker daemon is active or not, only if our Docker plugin is installed and connected to daemon. And, as far as I understand, IDE integration should only be responsible for .NET projects, everything else is a DCP thing.

@khalidabuhakmeh
Copy link
Author

Maybe this is an enhancement to the IntelliJ platform, allowing plugins to potentially watch for text that comes through the IO found in the run window and surface it in the form of a notification.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants