Add Arduino Uno Example #20
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I have independently got it working. I did it by forking the avr-hal and adding u8 delay_ms. While testing on a UNO clone, I noticed some issues, like cursor not working properly and found that currently, there is only 100 us delay, while the documentation requires 450 us delay. It is especially true for the clear method, which needs even larger delay. I also made a pull request to implement the u8 delay in AVR-HAL, so I don't think the change from u8 to u16 is needed. |
Marcuss2
reviewed
Aug 12, 2020
|
|
||
| //delay.delay_ms(500); | ||
|
|
||
| let mut lcd = HD44780::new_8bit( |
There was a problem hiding this comment.
It is more likely that 4bit interface will be used with Arduino UNO
|
The u8 delay in AVR-HAL was implemented, so I think just removing those changes from u8 to u16 should be enough at this point. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds an example for the Arduino Uno.
Closes #19
Todo