Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Indent with string | number | null #185

Open
sumbricht opened this issue Jul 12, 2021 · 0 comments
Open

Indent with string | number | null #185

sumbricht opened this issue Jul 12, 2021 · 0 comments

Comments

@sumbricht
Copy link
Contributor

I'm not a big fan it space indentation as I have a strong preference on tabs :-).
The TypeScript declaration currently defines ITypedJSONSettings.indent as number | null; I'm suggesting to change that to number | string | null.

As far as I can tell, nothing else needs to be changed as all you're doing with the indent property is pass it as 3rd parameter to JSON.stringify, which already accepts number | string as the "space" parameter.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant