Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No "Change action" confirmation modal when switching away from Advanced / Staged / Split payments #3466

Open
iamsamgibbs opened this issue Oct 24, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@iamsamgibbs
Copy link
Contributor

Steps to reproduce

  1. Create an advanced / staged / split payment and fill out some of the fields
  2. Change to a different action type

Expected behaviour

  • The "Do you wish to change action?" modal should appear

Actual behaviour

  • The action is changed without confirmation

Note the intended behaviour at the end of the video when switching away from Simple payment:
https://github.com/user-attachments/assets/ca7d5db3-3ef8-48bf-9e46-24eaa51e5e74

Suggestions (optional)

This is possibly due to the way validation is done on these actions as it is done on submit rather than on change, but this is just a hunch. If this is the case then it may be a fiddly issue to resolve.

@iamsamgibbs iamsamgibbs added the bug Something isn't working label Oct 24, 2024
@iamsamgibbs
Copy link
Contributor Author

Hmm actually I can't recreate this again now (even though there is video proof in the issue of it not working). Whoever picks this up, check it is actually broken on master first.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant