Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1.4.5 wheel on PyPI differs from source #125

Open
yurikhan opened this issue Aug 31, 2024 · 2 comments
Open

1.4.5 wheel on PyPI differs from source #125

yurikhan opened this issue Aug 31, 2024 · 2 comments
Labels
bug Something isn't working

Comments

@yurikhan
Copy link

Describe the bug

The code in the built distribution file on PyPI differs from that in the source distribution file and the Git tag 1.4.5.

To Reproduce

  1. pipx install i3-resurrect
  2. look in ~/.local/pipx/venvs/i3-resurrect/lib/python3.10/site-packages/i3_resurrect/main.py

Alternatively:

  1. cd /tmp && wget https://files.pythonhosted.org/packages/fe/30/362d39eaf8d0dc1869fb200bcd9141e545bfd17d703c8b3f4fa76bd0fd9c/i3_resurrect-1.4.5-py3-none-any.whl && unzip -d i3_resurrect-1.4.5-py3-none-any i3_resurrect-1.4.5-py3-none-any.whl
  2. look in /tmp/i3_resurrect-1.4.5-py3-none-any/i3_resurrect/main.py

Expected behavior

Code corresponds to main.py at tag 1.4.5; in particular, line 13 reads the directory key from config into a global DEFAULT_DIRECTORY variable which is further used as the default for the -d, --directory option.

Observed behavior

Code corresponds to 1.4.3, except for config.py which matches that of 1.4.5.

System information (please complete the following information):

  • Linux distribution: Ubuntu 22.04
  • i3-resurrect version (output of i3-resurrect --version): claims to be i3-resurrect, version 1.4.5
  • i3 version (output of i3 -v): i3 version 4.20.1 (2021-11-03) © 2009 Michael Stapelberg and contributors
  • Python version (output of python -V): Python 3.10.12
@yurikhan yurikhan added the bug Something isn't working label Aug 31, 2024
@yurikhan
Copy link
Author

Workaround: pipx install --pip-args=--no-binary=i3-resurrect i3-resurrect installs the source distribution which matches the 1.4.5 tag.

@JonnyHaystack
Copy link
Owner

Hmm not sure how that could've happened but it's been quite a few years. I should add a GitHub Actions pipeline for releases anyway.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants