Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removing backends in isrcsubmit2 #48

Open
JonnyJD opened this issue Feb 16, 2013 · 3 comments
Open

removing backends in isrcsubmit2 #48

JonnyJD opened this issue Feb 16, 2013 · 3 comments

Comments

@JonnyJD
Copy link
Owner

JonnyJD commented Feb 16, 2013

The original idea was to drop backends completely and use libdiscid ISRC support.

However, I think libdiscid 0.3.2 won't be in openSUSE 12.3 and also not in Ubunut 13.04.
This means, that many Linux users probably won't have a libdiscid version that supports ISRC reads (without using backports).

So we might drop only backends that only work in Windows and Mac OS X, since for these packages we ship libdiscid anyways.
Might keep supporting mediatools until libdiscid fixes metabrainz/libdiscid#6

Not sure if that makes sense anyways, since python-discid also won't be in the repos and we WILL use python-discid because python-musicbrainz2 doesn't work with Python 3.

So we might drop backends anyways.

(Feedback welcome)

EDIT:
It is already planned to maintain isrcsubmit1 for a while. At least until the dependencies of isrcsubmit2 are somewhat available.
We might also provide a backport PPA for libdiscid on some ubuntu releases.

@Freso
Copy link
Collaborator

Freso commented Feb 26, 2013

Personally, I think you might as well depend solely on libdiscid for future releases. Non-rolling releases likely won't update to 0.4.0/1.0 right away anyway, and may just as well pull in libdiscid when they do.

@JonnyJD
Copy link
Owner Author

JonnyJD commented Feb 26, 2013

Well, but currently there are two features that are still only available with other backends:

  1. LIB-11 raw ISRCs (somewhat rare)
  2. LIB-25 ISRCs in CD-TEXT (rare)

That means I would keep cdrdao (CD-TEXT) and mediatools (raw ISRCs) at least in the beta releases.
When these features are implemented in libdiscid, I could drop the backends. Possibly that happens before the 2.0.0 release.

Being implemented and released in libdiscid is enough though. I don't need for the changes to propagate to distributions for the reasons you stated. On Windows and Mac OS X I provide complete packages anyways.

JonnyJD added a commit that referenced this issue Apr 26, 2013
Some backends have features that libdiscid doesn't have.
That is raw reads and CD-TEXT isrcs.

Having discisrc as a backend is redundant, but this might come in handy
for testing purposes. Having different versions of libdiscid and
discisrc.
@jesus2099
Copy link
Contributor

jesus2099 commented May 27, 2016

LIB-11 from #5791, called raw ISRC, is not that rare, in my experience:

  • it is rare among good quality full size CD drives (or burners) — I have a NEC something only, never seen problem.
  • it is very frequent in slim CD drives (or burners) — I have tested many slims of several brands (Samsung, etc.), they all had this bug when not using the secure repeated raw algorithm described in those tickets (that mediatools provides)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants