Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Read ISRCs from CUE files #11

Closed
JonnyJD opened this issue Feb 1, 2013 · 4 comments
Closed

Read ISRCs from CUE files #11

JonnyJD opened this issue Feb 1, 2013 · 4 comments

Comments

@JonnyJD
Copy link
Owner

JonnyJD commented Feb 1, 2013

Requested in JonnyJD/musicbrainz-isrcsubmit#42

That obviously would make use of DiscId.put(), but we might even implement gathering the data from the CUE files in the discid module.

That would be the first function that is not just forwarded to libdiscid.

@JonnyJD
Copy link
Owner Author

JonnyJD commented Feb 1, 2013

We have to check if we get the same ID, even for data CDs. Possibly we need to detect data CDs and handle them differently.

@JonnyJD
Copy link
Owner Author

JonnyJD commented Feb 1, 2013

Another option might even be to implement that part in libdiscid, when special handling is necessary.

@JonnyJD
Copy link
Owner Author

JonnyJD commented Feb 2, 2013

Not much special handling is necessary. We just have to make sure that we only input last AUDIO track and don't append an offset for the (appended) data track.

We could possibly still include that in libdiscid, although parsing files is easier in python, I guess.

@JonnyJD
Copy link
Owner Author

JonnyJD commented Apr 9, 2013

cue sheets alone are not enough. They are missing overall length. kepstin/image-id#1 might be a better place to implement this.

@JonnyJD JonnyJD closed this as completed Apr 9, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant