-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
integration for kommentary #10
Comments
@yamatsum b3nj5m1n/kommentary#43 No need to do anything on this plugin's side. |
The kommentary integration looks great! I'll add a note about it in the README. @yamatsum About commenting twice in JSX, that seems to be a problem in general, not directly related to kommentary. The issue is that if you comment the first line (only the first line) in any JSX block, then there will be a syntax error. For example, this is not valid JS/JSX: const App = () => (
{/* <div> */}
<p>Hello world</p>
</div>
) Now, treesitter thinks that the first line of JSX with the comment is an I created an issue for this: #11 but I don't think that it's super high priority for now. I probably won't be dealing with it any time soon. Toggling comments of other bits of JSX seems to work fine though, so I hope that it's OK at the moment. Hopefully it won't be necessary to comment the first line of JSX very often 😃 |
https://github.com/b3nj5m1n/kommentary
The text was updated successfully, but these errors were encountered: