fix(jsx): correctly comment first line of JSX #56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The first and last lines of JSX should be commented with `// %s`, rather
than `{/* %s */}`. However, the current way of configuring the plugin
does not allow us to check if the current node is a `jsx_element` with a
parent of `parenthesized_expression`. We could allow checking the parent
node in the configuration, but that would be a bit tricky and a lot of
work.
Since this is (hopefully) a 1-time exception, then it seems okay to add
an explicit check for this. If we have similar cases in the future
though, then we should think of making this configurable somehow.
Fixes #29
|
A maybe viable idea - generalize this to alternates with an optional "only child" configuration directive. E.g.: Then, when checking the node, alternates can be checked with something like A similar "parent" directive could be employed too. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The first and last lines of JSX should be commented with
// %s, rather than{/* %s */}. However, the current way of configuring the plugin does not allow us to check if the current node is ajsx_elementwith a parent ofparenthesized_expression. We could allow checking the parent node in the configuration, but that would be a bit tricky and a lot of work.Since this is (hopefully) a 1-time exception, then it seems okay to add an explicit check for this. If we have similar cases in the future though, then we should think of making this configurable somehow.
Fixes #29