Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request for Support for GB2312 Encoding in Your Library #2272

Open
qq786838943 opened this issue Jul 2, 2024 · 1 comment
Open

Request for Support for GB2312 Encoding in Your Library #2272

qq786838943 opened this issue Jul 2, 2024 · 1 comment
Labels

Comments

@qq786838943
Copy link

I am a dedicated user of your library and appreciate the excellent tools you provide. However, I have encountered a challenge while working with GB2312 encoded text files. GB2312 remains a common character encoding in China, particularly for maintaining and converting data from legacy systems.

I've noticed that your library currently does not support GB2312 encoding, which prevents me from using your tools directly for handling such files. Therefore, I kindly request your team to consider adding support for GB2312 encoding in future versions of the library.

I would be happy to provide further details about the practical use cases and benefits of supporting GB2312 encoding. I believe this enhancement would not only resolve my current issue but also benefit many other developers who rely on GB2312 encoding.

Looking forward to your response. Thank you for your attention to this matter.

Best regards,

@qq786838943 qq786838943 added the bug label Jul 2, 2024
@JoshClose
Copy link
Owner

What issues are you having? CsvHelper knows nothing about the encoding you're using. You pass in a TextReader which is where encoding is handled. If you're using a StreamReader, you would set the encoding there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants