-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Word boundary errors possible #24
Comments
Yeah, and car rot. I have a list of them somewhere. I wasn't sure how to handle that: would we need the whole Plover dictionary to find them? I was reluctant to slow the loading more by adding another even bigger data file, but I suppose most people use it enough that it's just in cache all the time. And if Twitter can ask you to load 9MB of crap to read a 140-character message, then I suppose it's OK to ask you to load three or four to do something useful. But yeah, go for it. |
I was thinking that maybe we brute force and look up all the combinations
in main.json and build a small word boundaries dictionary in order to not
hold the whole dictionary.
…On Wed, Oct 4, 2017 at 8:17 AM, Joshua Grams ***@***.***> wrote:
Yeah, and car rot. I have a list of them somewhere. I wasn't sure how to
handle that: would we need the whole Plover dictionary to find them? I was
reluctant to slow the loading more by adding another even bigger data file,
but I suppose most people use it enough that it's just in cache all the
time. And if Twitter can ask you to load 9MB of crap to read a
140-character message, then I suppose it's OK to ask you to load three or
four to do something useful.
But yeah, go for it.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#24 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AFkgSsDywUpMblwg9w9bQuz8LzVOcl-wks5so3dXgaJpZM4PskzD>
.
|
Ah, that could work. |
While doing the single-syllable exercise, I've run into word boundary errors, such as:
Kass set
→cassette
pup pet
→puppet
It would be nice if the lesson was aware of these entries and never suggested "pup pet" or "Kass set". Maybe more generally, all random lessons could be checked for word boundary errors.
I'd be willing to work through a solution and make a PR if you are open to it.
The text was updated successfully, but these errors were encountered: