Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Word boundary errors possible #24

Open
TheaMorin opened this issue Oct 3, 2017 · 3 comments
Open

Word boundary errors possible #24

TheaMorin opened this issue Oct 3, 2017 · 3 comments

Comments

@TheaMorin
Copy link

While doing the single-syllable exercise, I've run into word boundary errors, such as:

  • Kass setcassette
  • pup petpuppet

It would be nice if the lesson was aware of these entries and never suggested "pup pet" or "Kass set". Maybe more generally, all random lessons could be checked for word boundary errors.

I'd be willing to work through a solution and make a PR if you are open to it.

@JoshuaGrams
Copy link
Owner

Yeah, and car rot. I have a list of them somewhere. I wasn't sure how to handle that: would we need the whole Plover dictionary to find them? I was reluctant to slow the loading more by adding another even bigger data file, but I suppose most people use it enough that it's just in cache all the time. And if Twitter can ask you to load 9MB of crap to read a 140-character message, then I suppose it's OK to ask you to load three or four to do something useful.

But yeah, go for it.

@TheaMorin
Copy link
Author

TheaMorin commented Oct 4, 2017 via email

@JoshuaGrams
Copy link
Owner

Ah, that could work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants