Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🛠 Tooling: Tests should snapshot parsed options #1529

Closed
3 tasks done
rubiesonthesky opened this issue Apr 5, 2024 · 0 comments · Fixed by #1530
Closed
3 tasks done

🛠 Tooling: Tests should snapshot parsed options #1529

rubiesonthesky opened this issue Apr 5, 2024 · 0 comments · Fixed by #1530
Labels
area: tests Testing infrastructure or gaps/errors in coverage area: tooling Managing the repository's maintenance 🛠️ status: accepting prs Please, send a pull request to resolve this! 🙏

Comments

@rubiesonthesky
Copy link
Collaborator

rubiesonthesky commented Apr 5, 2024 •
edited
Loading

Bug Report Checklist

  • I have tried restarting my IDE and the issue persists.
  • I have pulled the latest main branch of the repository.
  • I have searched for related issues and found none that matched my issue.

Overview

I propose that every integration test would generate snapshot of the options it parsed from the given files. That way it will be easier to track changes for code that does this parsing.

Additional Info

I think we can see in the snapshots part of the problem in #1532 - however, it could also be oversight in the testing system.
@rubiesonthesky rubiesonthesky added area: tests Testing infrastructure or gaps/errors in coverage area: tooling Managing the repository's maintenance 🛠️ status: accepting prs Please, send a pull request to resolve this! 🙏 labels Apr 5, 2024
@rubiesonthesky rubiesonthesky mentioned this issue Apr 5, 2024
Merged
3 tasks
rubiesonthesky added a commit that referenced this issue Apr 7, 2024
@rubiesonthesky
chore(tests): snapshot mutation options (#1530)
edfc365 
## PR Checklist

- [x] Addresses an existing open issue: fixes #1529
- [x] That issue was marked as [`status: accepting
prs`](https://github.com/JoshuaKGoldberg/TypeStat/issues?q=is%3Aopen+is%3Aissue+label%3A%22status%3A+accepting+prs%22)
- [x] Steps in
[CONTRIBUTING.md](https://github.com/JoshuaKGoldberg/TypeStat/blob/main/.github/CONTRIBUTING.md)
were taken 🐕

## Overview

Snapshot options used in integration tests.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area: tests Testing infrastructure or gaps/errors in coverage area: tooling Managing the repository's maintenance 🛠️ status: accepting prs Please, send a pull request to resolve this! 🙏
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore(tests): snapshot mutation options rubiesonthesky/TypeStat
1 participant
@rubiesonthesky