From a415ced4b9dc4a18b55061e19d9fbb1ebc65597e Mon Sep 17 00:00:00 2001
From: Juan A <30204147+jaas666@users.noreply.github.com>
Date: Mon, 11 Dec 2023 19:54:40 -0600
Subject: [PATCH] chore: cleanup --report-unused-disable-directives (#1093)
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
<!-- 👋 Hi, thanks for sending a PR to create-typescript-app! 💖.
Please fill out all fields below and make sure each item is true and [x]
checked.
Otherwise we may not be able to review your PR. -->
## PR Checklist
- [x] Addresses an existing open issue: fixes #1089
- [x] That issue was marked as [`status: accepting
prs`](https://github.com/JoshuaKGoldberg/create-typescript-app/issues?q=is%3Aopen+is%3Aissue+label%3A%22status%3A+accepting+prs%22)
- [x] Steps in
[CONTRIBUTING.md](https://github.com/JoshuaKGoldberg/create-typescript-app/blob/main/.github/CONTRIBUTING.md)
were taken
## Overview
Removes all references to `--report-unused-disable-directives`
---
src/steps/writing/creation/writePackageJson.test.ts | 4 ++--
src/steps/writing/creation/writePackageJson.ts | 2 +-
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/src/steps/writing/creation/writePackageJson.test.ts b/src/steps/writing/creation/writePackageJson.test.ts
index 95a26f594..8ef9e7ec1 100644
--- a/src/steps/writing/creation/writePackageJson.test.ts
+++ b/src/steps/writing/creation/writePackageJson.test.ts
@@ -102,7 +102,7 @@ describe("writePackageJson", () => {
"scripts": {
"build": "tsup",
"format": "prettier "**/*" --ignore-unknown",
- "lint": "eslint . .*js --max-warnings 0 --report-unused-disable-directives",
+ "lint": "eslint . .*js --max-warnings 0",
"lint:knip": "knip",
"lint:md": "markdownlint "**/*.md" ".github/**/*.md" --rules sentences-per-line",
"lint:package-json": "npmPkgJsonLint .",
@@ -172,7 +172,7 @@ describe("writePackageJson", () => {
"scripts": {
"build": "tsup",
"format": "prettier "**/*" --ignore-unknown",
- "lint": "eslint . .*js --max-warnings 0 --report-unused-disable-directives",
+ "lint": "eslint . .*js --max-warnings 0",
"prepare": "husky install",
"tsc": "tsc",
},
diff --git a/src/steps/writing/creation/writePackageJson.ts b/src/steps/writing/creation/writePackageJson.ts
index 027f7fa89..c25d8b821 100644
--- a/src/steps/writing/creation/writePackageJson.ts
+++ b/src/steps/writing/creation/writePackageJson.ts
@@ -78,7 +78,7 @@ export async function writePackageJson(options: Options) {
scripts: {
build: "tsup",
format: 'prettier "**/*" --ignore-unknown',
- lint: "eslint . .*js --max-warnings 0 --report-unused-disable-directives",
+ lint: "eslint . .*js --max-warnings 0",
...(!options.excludeLintKnip && {
"lint:knip": "knip",
}),