Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🚀 Feature: Bring in a valid-homepage rule #828

Open
3 tasks done
JoshuaKGoldberg opened this issue Feb 1, 2025 · 0 comments
Open
3 tasks done

🚀 Feature: Bring in a valid-homepage rule #828

JoshuaKGoldberg opened this issue Feb 1, 2025 · 0 comments
Labels
status: blocked Waiting for something else to be resolved type: feature New enhancement or request

Comments

@JoshuaKGoldberg
Copy link
Owner

Bug Report Checklist

  • I have tried restarting my IDE and the issue persists.
  • I have pulled the latest main branch of the repository.
  • I have searched for related issues and found none that matched my issue.

Overview

Following #42 -> #51: we've resolved to create a standalone valid-homepage rule. It should enforce that, if the field exists in the package.json file, it's set to a valid value. It should do nothing if the field doesn't exist.

Additional Info

Per discussion in #51, this won't be enabled by default at first. The valid-package-def rule already contains this logic using package-json-validator. For this issue, we should:

  1. File an issue on https://github.com/JoshuaKGoldberg/package-json-validator to create a standalone API to validate this specific field
  2. Send a PR to add API to package-json-validator
  3. Once a version of package-json-validator is released with this field's API, mark this issue as unblocked
  4. Send a PR to this repo adding in a standalone rule for this field - without adding it to the recommended config

Once all valid- rules exist in this plugin, we can then file an issue to deprecate the valid-package-def rule in favor of them.

💖

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: blocked Waiting for something else to be resolved type: feature New enhancement or request
Projects
None yet
Development

No branches or pull requests

1 participant