Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transfer from DCS contrib to jupyter notebook yields error #44

Closed
valentinsteier opened this issue Jun 13, 2022 · 5 comments
Closed

Transfer from DCS contrib to jupyter notebook yields error #44

valentinsteier opened this issue Jun 13, 2022 · 5 comments
Assignees

Comments

@valentinsteier
Copy link

valentinsteier commented Jun 13, 2022

grafik

Copying the code from DCS contrib server yields the error in the screenshot


⚠ This issue is about FZJ-internal code.

@michaelosthege
Copy link
Member

michaelosthege commented Jun 13, 2022

Huh, you got me. I didn't test that code.

The error was probably in this block, right?

calibr8.fit_scipy(
    cmodel,
    independent=cal_independent,
    dependent=cal_dependent,
    theta_guess=[0.0, 1.0, 0.1],
    theta_bounds=[
        (-5.0, 5.0),
        (-1.0, 10.0),
        (0.001, 1.0),
    ],
)

Try to change these two lines:

    independent=cal_independent.to_numpy(),
    dependent=cal_dependent.to_numpy(),

if you can confirm that this change works, I'll fix it ASAP.

@valentinsteier
Copy link
Author

thanks for the quick response! works fine, does yield a warning though:
grafik

@michaelosthege
Copy link
Member

data says no

So it wants an even more negative symmetry parameter...

But with this dataset, did you consider the Exponential model?
With the parametrization shown in the lower-left quadrant of the figure in the documentation this could be a rather okay fit.

(Nevertheless, your data looks ...challenging...)

@valentinsteier
Copy link
Author

challenging might be an understatement :D

I'll take a look, thanks for the suggestion!

@michaelosthege
Copy link
Member

michaelosthege commented Jun 13, 2022

Underlying issue in another project was closed by a Merge Request in that project.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants