Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make an initial version of juicy-tooltip #1

Open
warpech opened this issue Mar 12, 2018 · 3 comments
Open

Make an initial version of juicy-tooltip #1

warpech opened this issue Mar 12, 2018 · 3 comments

Comments

@warpech
Copy link

warpech commented Mar 12, 2018

Juicy-tooltip should implement the following design (source):

all routes

image

With the following API:

<th>
<juicy-tooltip>
  <div slot="tooltip">If this option is on user can use regular expressions in route URI</div>
  Use regular expression
</juicy-tooltip>
</th>

Internally, it should use <juicy-popover position="beforetop center" expand-on="mouseover"> as implemented by:


The files in this repo can be based on https://github.com/Juicy/juicy-popover or https://github.com/Juicy/juicy-element-boilerplate

@warpech
Copy link
Author

warpech commented Mar 13, 2018

Actually, internally it should be:

<juicy-popover position="beforetop center, bottom center, bottom left, 
bottom beforeright, beforetop left, beforetop beforeright" expand-on="hover">

So that there are fallback positions if it does not fit on top.

@PatrykSzwer PatrykSzwer removed their assignment Mar 21, 2018
@warpech warpech added this to the Uniform Components initial work milestone Apr 3, 2018
@warpech
Copy link
Author

warpech commented Apr 11, 2018

I think that we could skip doing it as juicy-tooltip and do it as uni-tooltip instead. Usage:

Light DOM:

<table slot="table">
...
   <th title="Description ....">column header</th>
...
</table>

Shadow DOM

<uni-tooltip>
  <slot name="table></slot>
</uni-tooltip>

Uni-tooltip hijacks all title attributes and presents them as nice tooltips on mouse over.

@tomalec WDYT?

@tomalec
Copy link
Member

tomalec commented Jun 7, 2018

Uni-tooltip hijacks all title attributes and presents them as nice tooltips on mouse over.

I'm mostly concerned about "all":

  • how deep? is it just to for a table to support table>tbody|thead>tr>td|th, table>tr>td|th? then it's rather uni-table-tooltip
  • should it also support dested distribution?
    <uni-tooltip>
    	  <my-table><slot name="table slot="my-table-data"></slot></my-table>
    </uni-tooltip>

Then, do you want to support any other tooltips content that text? How would you like to use icons, images, links?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants