From aed25f53f792f4b5639be7f05bd2b2b667fc6e4b Mon Sep 17 00:00:00 2001 From: Jishnu Bhattacharya Date: Tue, 31 Oct 2023 15:26:01 +0530 Subject: [PATCH 1/3] Import deps transitively in SparseArray extension --- ext/FillArraysSparseArraysExt.jl | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/ext/FillArraysSparseArraysExt.jl b/ext/FillArraysSparseArraysExt.jl index 6a82f246..c5a674df 100644 --- a/ext/FillArraysSparseArraysExt.jl +++ b/ext/FillArraysSparseArraysExt.jl @@ -1,10 +1,12 @@ module FillArraysSparseArraysExt using SparseArrays -import Base: convert, kron using FillArrays using FillArrays: RectDiagonalFill, RectOrDiagonalFill, ZerosVector, ZerosMatrix, getindex_value -using LinearAlgebra +# Specifying the full namespace is necessary because of https://github.com/JuliaLang/julia/issues/48533 +# See https://github.com/JuliaStats/LogExpFunctions.jl/pull/63 +import SparseArrays.Base: convert, kron +using FillArrays.LinearAlgebra ################## ## Sparse arrays From beb1c566e0e368cd2c329074db9fef146ba60c58 Mon Sep 17 00:00:00 2001 From: Jishnu Bhattacharya Date: Wed, 6 Dec 2023 23:11:19 +0530 Subject: [PATCH 2/3] exclude Base --- ext/FillArraysSparseArraysExt.jl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ext/FillArraysSparseArraysExt.jl b/ext/FillArraysSparseArraysExt.jl index c5a674df..a4441a1a 100644 --- a/ext/FillArraysSparseArraysExt.jl +++ b/ext/FillArraysSparseArraysExt.jl @@ -5,7 +5,7 @@ using FillArrays using FillArrays: RectDiagonalFill, RectOrDiagonalFill, ZerosVector, ZerosMatrix, getindex_value # Specifying the full namespace is necessary because of https://github.com/JuliaLang/julia/issues/48533 # See https://github.com/JuliaStats/LogExpFunctions.jl/pull/63 -import SparseArrays.Base: convert, kron +import Base: convert, kron using FillArrays.LinearAlgebra ################## From f4b85480bf7764dd2074050d52e8dbcc8df78c4f Mon Sep 17 00:00:00 2001 From: Jishnu Bhattacharya Date: Thu, 7 Dec 2023 16:29:40 +0530 Subject: [PATCH 3/3] Move comment --- ext/FillArraysSparseArraysExt.jl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ext/FillArraysSparseArraysExt.jl b/ext/FillArraysSparseArraysExt.jl index a4441a1a..a33b89d8 100644 --- a/ext/FillArraysSparseArraysExt.jl +++ b/ext/FillArraysSparseArraysExt.jl @@ -3,9 +3,9 @@ module FillArraysSparseArraysExt using SparseArrays using FillArrays using FillArrays: RectDiagonalFill, RectOrDiagonalFill, ZerosVector, ZerosMatrix, getindex_value +import Base: convert, kron # Specifying the full namespace is necessary because of https://github.com/JuliaLang/julia/issues/48533 # See https://github.com/JuliaStats/LogExpFunctions.jl/pull/63 -import Base: convert, kron using FillArrays.LinearAlgebra ##################