Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Benchmarks and benchmark CI #401

Open
Krastanov opened this issue May 15, 2023 · 2 comments
Open

Benchmarks and benchmark CI #401

Krastanov opened this issue May 15, 2023 · 2 comments

Comments

@Krastanov
Copy link

A number of packages in the ecosystem run benchmarks are part of pull request tests, e.g.

https://github.com/aviatesk/JET.jl/blob/master/.github/workflows/benchmark.yml
https://github.com/aviatesk/JET.jl/blob/master/.github/workflows/benchmark-comment.yml

@gdalle
Copy link
Collaborator

gdalle commented Jul 31, 2023

Linked to #86 and #261

@gdalle
Copy link
Collaborator

gdalle commented Dec 18, 2023

Partial answer in #261

In addition to CI scripts, another nice addition would be automatic creation of benchmark/Project.toml and benchmark/Manifest.toml

Perhaps even testing that PkgBenchmark.jl runs correctly?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants