Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PRE REVIEW]: FMIExchange.jl: Foreign Models Through a Familiar Interface #176

Open
editorialbot opened this issue Jan 15, 2025 · 20 comments

Comments

@editorialbot
Copy link
Collaborator

editorialbot commented Jan 15, 2025

Submitting author: @CasBex (Lucas Bex)
Repository: https://github.com/Electa-Git/FMIExchange.jl
Branch with paper.md (empty if default branch): paper
Version: v0.1.0
Editor: @fcdimitr
Reviewers: @H-Sax
Managing EiC: Luca Ferranti

Status

status

Status badge code:

HTML: <a href="https://proceedings.juliacon.org/papers/d708cef8270085f152a7564813fc2683"><img src="https://proceedings.juliacon.org/papers/d708cef8270085f152a7564813fc2683/status.svg"></a>
Markdown: [![status](https://proceedings.juliacon.org/papers/d708cef8270085f152a7564813fc2683/status.svg)](https://proceedings.juliacon.org/papers/d708cef8270085f152a7564813fc2683)

Author instructions

Thanks for submitting your paper to JCON @CasBex. Currently, there isn't a JCON editor assigned to your paper.

The AEiC suggestion for the handling editor is @fcdimitr.

@CasBex if you have any suggestions for potential reviewers then please mention them here in this thread (without tagging them with an @). You can search the list of people that have already agreed to review and may be suitable for this submission.

Editor instructions

The JCON submission bot @editorialbot is here to help you find and assign reviewers and start the main review. To find out what @editorialbot can do for you type:

@editorialbot commands
@editorialbot
Copy link
Collaborator Author

Hello human, I'm @editorialbot, a robot that can help you with some common editorial tasks.

For a list of things I can do to help you, just type:

@editorialbot commands

For example, to regenerate the paper pdf after making changes in the paper source files, type:

@editorialbot generate pdf

@lucaferranti
Copy link
Member

@editorialbot assign @fcdimitr as editor

@editorialbot
Copy link
Collaborator Author

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

✅ OK DOIs

- 10.5334/jors.151 is OK
- 10.3384/ecp21181297 is OK

🟡 SKIP DOIs

- No DOI given, and none found for title: Functional Mock-up Interface
- No DOI given, and none found for title: Functional Mock-Up Interface for Model Exchange an...

❌ MISSING DOIs

- None

❌ INVALID DOIs

- None

@editorialbot
Copy link
Collaborator Author

Software report:

github.com/AlDanial/cloc v 1.98  T=0.03 s (1285.1 files/s, 218829.1 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
TeX                              8            239            182           2342
CSV                              2              0              0           1422
XML                              2              2              0           1179
Julia                           14            127            199            558
Markdown                         6             70              0            459
YAML                             6             30             10            326
Dockerfile                       1              6              1             64
Ruby                             1              8              4             45
TOML                             2              4              0             30
Bourne Shell                     1              0              0             15
-------------------------------------------------------------------------------
SUM:                            43            486            396           6440
-------------------------------------------------------------------------------

Commit count by author:

    14	Cas Bex
     1	CasBex

@editorialbot
Copy link
Collaborator Author

Assigned! @fcdimitr is now the editor

@editorialbot
Copy link
Collaborator Author

Paper file info:

📄 Wordcount for paper.tex is 1316

🔴 Failed to discover a Statement of need section in paper

@editorialbot
Copy link
Collaborator Author

License info:

✅ License found: BSD 3-Clause "New" or "Revised" License (Valid open source OSI approved license)

@editorialbot
Copy link
Collaborator Author

👉📄 Download article proof 📄 View article proof on GitHub 📄 👈

@lucaferranti
Copy link
Member

@editorialbot assign @fcdimitr as editor

@editorialbot
Copy link
Collaborator Author

Assigned! @fcdimitr is now the editor

@CasBex
Copy link

CasBex commented Jan 20, 2025

Please find below some people who may be suitable for review, in no particular order.

  • mongibellili (full disclosure, this person works at the same university as me, but I have never met him and he works in a different department)
  • brianguenter
  • H-Sax
  • sloede

As an extra mention, I believe that Tobias Thummerer (ThummeTo on GitHub) would be an excellent reviewer. He is the main developer of the FMI.jl package which is very closely related to this work. He has not volunteered to review, but if it is acceptable to the editors, I could contact him to ask whether he would review this paper.

@fcdimitr
Copy link

Hi @brianguenter 👋 ,

would you like to review this JuliaCon proceedings submission?

you can read more about reviewing for JuliaCon proceedings in the reviewer guide.

@fcdimitr
Copy link

Hi @H-Sax 👋 ,

would you like to review this JuliaCon proceedings submission?

you can read more about reviewing for JuliaCon proceedings in the reviewer guide.

@fcdimitr
Copy link

Hi @sloede 👋 ,

would you like to review this JuliaCon proceedings submission?

you can read more about reviewing for JuliaCon proceedings in the reviewer guide.

@brianguenter
Copy link

brianguenter commented Feb 27, 2025

I looked at the github repo. This is not a package I would ordinarily use or have much familiarity with, since I don't use differential equations much. I'm willing to review if no more qualified reviewers step up.

@H-Sax
Copy link

H-Sax commented Feb 27, 2025

Happy to review just let me know what needs to be done :)

@fcdimitr
Copy link

@editorialbot add @H-Sax as reviewer

@editorialbot
Copy link
Collaborator Author

@H-Sax added to the reviewers list!

@fcdimitr
Copy link

Thank you, @H-Sax! Once we have two reviewers, we will create a separate [REVIEW] issue with further instructions.

@sloede
Copy link
Collaborator

sloede commented Mar 4, 2025

Similar to Brian, I do not have experience with FMUs nor am I an expert on DAEs. Thus I suggest to look for someone with real expertise in the field, but I'd be willing to participate in case no better qualified reviewer can be found.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants